[Maps][Vega] Tidy up mapbox-gl imports

[thomasneirynck]

This PR tidies up some of the mapbox-gl import inconsistencies between Maps and Vega

• removes redundant css import from Maps
• uses csp-approved worker loading in vega

This should make the mapbox-gl -> maplibre-gl switch more clean, restricting it to the imports and the yarn.lock change.

Open questions: as suggested here #85566 (comment), we can also isolate mapbox-gl loading in single plugin, further improving the use of the library. this will also reduce total kibana bundle size, since it won't get packaged with two plugins. (although, the dependency is lazy-loaded, it would only affect total kibana size, not necessarily kibana startup time).

[nreese]

LGTM
code review

[stratoula]

@thomasneirynck can you give me more info about this worker? Why are we adding this? Sorry, I don't have a lot of experience with mapbox :D

[thomasneirynck]

hi @stratoula, this bring vegamaps in line with how mapbox maps are instantiated in Maps (

kibana/x-pack/plugins/maps/public/connected_components/mb_map/mb_map.tsx

Lines 49 to 55 in 158fff3

	// @ts-expect-error
	import mbRtlPlugin from '!!file-loader!@mapbox/mapbox-gl-rtl-text/mapbox-gl-rtl-text.min.js';
	// @ts-expect-error
	import mbWorkerUrl from '!!file-loader!mapbox-gl/dist/mapbox-gl-csp-worker';
	mapboxgl.workerUrl = mbWorkerUrl;
	mapboxgl.setRTLTextPlugin(mbRtlPlugin);

)

These workers are spawned by mapbox-gl.

This PR changes Vegamaps, so it constructs mapbox with a static-worker script (pointing explicitly to mbWorkerUrl), iso. an inlined string which is the default way mapbox instantiates its workers.

The latter approach was hitting on some possible violations of Kibana's CSP. See #51675.

Apart from that, construction is now the same between Maps and Vega, so it would also give us a pathway to extract mapbox-gl into a separate bundle, reducing footprint.

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 4a5efae
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
visTypeVega	241	243	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
visTypeVega	2.6MB	2.6MB	-71.1KB

Unknown metric groups

miscellaneous assets size

id	before	after	diff
visTypeVega	0.0B	550.3KB	⚠️ +550.3KB

References to deprecated APIs

id	before	after	diff
canvas	29	25	-4
crossClusterReplication	8	6	-2
fleet	4	2	-2
globalSearch	4	2	-2
indexManagement	12	7	-5
infra	5	3	-2
licensing	18	15	-3
monitoring	109	56	-53
total			-73

History

• 💔 Build #125328 failed b6cc196
• 💔 Build #125306 failed 4e53c3c
• 💔 Build #125220 failed 8cabef7
• 💔 Build #125219 failed 7bf813a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[stratoula]

Thank you Thomas, LGTM!