Skip to content

Add info notifications for each panel added to a dashboard#9961

Closed
stacey-gammon wants to merge 1 commit intoelastic:masterfrom
stacey-gammon:visual-add-panel-indicator
Closed

Add info notifications for each panel added to a dashboard#9961
stacey-gammon wants to merge 1 commit intoelastic:masterfrom
stacey-gammon:visual-add-panel-indicator

Conversation

@stacey-gammon
Copy link
Copy Markdown

@stacey-gammon stacey-gammon commented Jan 19, 2017

It can be confusing that clicking on a saved search or visualization added a panel, especially if you have a long list of visualizations, or a few panels already on the dashboard.

Fixes part of #8633.

addnotify

@stacey-gammon
Copy link
Copy Markdown
Author

ping @tbragin @alexfrancoeur @kobelb any thoughts on the above? I think it much improves the experience with a teeny code change.

@kobelb
Copy link
Copy Markdown
Contributor

kobelb commented Jan 24, 2017

I definitely think we could benefit from having it be more obvious when a panel is added to the dashboard, I have mixed feelings about using the toast notifications for it though. It is the most consistent way to alert the user of something; however, I have at times found it to be frustrating how it moves elements on the page down.

If we added multiple panels quickly after each other, will we continue to get new toast notifications that "stack up"?

Might be beneficial to add this to the weekly UI Review.

@stacey-gammon
Copy link
Copy Markdown
Author

Yea, I hate that too, and I think the design team is working on something to get rid of that page movement. This isn't perfect (indication in the table would be better, but more work), but for an interim solution, it's better than the current, IMO.

Can def add it to a design review for more feedback.

@alexfrancoeur
Copy link
Copy Markdown

alexfrancoeur commented Jan 27, 2017

@stacey-gammon I think this is a better approach than what Kibana currently offers. There is currently no confirmation that a visualization has been added. Once a users visualizations are under the fold, they are adding them blindly to dashboards. Any way you look at it, I believe this is an improvement.

I agree with the concerns from @kobelb as well. The use case I had really noticed this issue on was adding a large number of visualizations to a dashboard. For this scenario, I could see the stacked notifications being a bit distracting.

I'd be interesting in hearing more about the new designs for toasts in general. There are more modern material visualizations available in angular that look clean and float rather than affect the content already on the page.

https://material.angularjs.org/latest/demo/toast
toast

@stacey-gammon
Copy link
Copy Markdown
Author

One possible solution is to remove the name of the visualization you are adding from the info. Then there will only be at max one, since they will collapse down (or two if you add both a visualization and a search).

manyadds

@alexfrancoeur
Copy link
Copy Markdown

@stacey-gammon apologies for not answering earlier, my gmail filters had some issues apparently. Should be resolved now. I think this resolves the @kobelb's concern. I like the count of visualizations added as well. Looks good to me!

@kobelb
Copy link
Copy Markdown
Contributor

kobelb commented Feb 9, 2017

@stacey-gammon I like this approach as well, seems to be the best solution we have at the moment.

@stacey-gammon
Copy link
Copy Markdown
Author

Replaced by #10310

@stacey-gammon stacey-gammon deleted the visual-add-panel-indicator branch April 6, 2017 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Dashboard Dashboard related features review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants