[kbn/test] move types/ftr into src#99555
Merged
spalger merged 5 commits intoelastic:masterfrom May 17, 2021
Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
YulNaumenko
approved these changes
May 7, 2021
Contributor
YulNaumenko
left a comment
YulNaumenko
left a comment
There was a problem hiding this comment.
Alerting changes LGTM!
botelastic
bot
added
Team:APM - DEPRECATED
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
mshustov
approved these changes
May 7, 2021
dgieselaar
approved these changes
May 7, 2021
azasypkin
approved these changes
May 7, 2021
ppisljar
approved these changes
May 10, 2021
Contributor
ppisljar
left a comment
ppisljar
left a comment
There was a problem hiding this comment.
app services changes LGTM
JasonStoltz
approved these changes
May 10, 2021
jbudz
approved these changes
May 10, 2021
dmlemeshko
approved these changes
May 10, 2021
Contributor
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
Kibana-qa changes LGTM
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
spalger
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 17, 2021
* [kbn/test] move types/ftr into src * Apply eslint updates * fix import of Lifecycle type Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
May 17, 2021
* [kbn/test] move types/ftr into src * Apply eslint updates * fix import of Lifecycle type Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/functional_cors/config.ts # x-pack/test/reporting_functional/reporting_and_deprecated_security.config.ts
kibanamachine
added a commit
that referenced
this pull request
May 17, 2021
* [kbn/test] move types/ftr into src * Apply eslint updates * fix import of Lifecycle type Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Spencer <email@spalger.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
backport missing
spalger
pushed a commit
that referenced
this pull request
May 19, 2021
* [kbn/test] move types/ftr into src * Apply eslint updates * fix import of Lifecycle type Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/functional_cors/config.ts # x-pack/test/reporting_functional/reporting_and_deprecated_security.config.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
* [kbn/test] move types/ftr into src * Apply eslint updates * fix import of Lifecycle type Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #99546
In order to support defining additional public ftr types we need to convert the
ftr.d.tsfile to be a concrete TS file, which means moving it into the src directory and rewriting all the imports for@kbn/test/types/ftrto@kbn/test. This PR focuses on that change with two commits, one with the functional changes and the other with all the import path updates which are all over the place and automatically applied and verified by eslint.