Skip to content

Hide time navigation buttons #9909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spalger merged 1 commit into from
Jan 17, 2017
Merged

Hide time navigation buttons #9909

spalger merged 1 commit into from
Jan 17, 2017

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Jan 17, 2017

Hides the time navigation buttons in preparation for 5.2.0

@uboness
Copy link

uboness commented Jan 17, 2017

we haven't decided to remove those yet, have we?

@spalger
Copy link
Contributor Author

spalger commented Jan 17, 2017

not totally, but have this here in case we do

@spalger spalger added the review label Jan 17, 2017
@lukasolson
Copy link
Contributor

lukasolson commented Jan 17, 2017

LGTM.

A minor concern of mine is that we merged a pull request that automatically closes the timepicker when a user selects a time range. There was some discussion about this and ultimately it was decided that the benefits outweighed the drawbacks and that the step forward/backward buttons helped mitigate the use case where users would want to select different time ranges without re-opening the timepicker (see #9218 (comment)). @tbragin, do you have any thoughts about that? I guess I'm wondering if we should be reverting that PR as well.

@spalger spalger merged commit c1ee655 into elastic:master Jan 17, 2017
elastic-jasper added a commit that referenced this pull request Jan 17, 2017
@elastic-jasper
Hide time navigation buttons
94faf33 
Backports PR #9909

**Commit 1:**
[ui/timepicker] hide time navigation buttons for now

* Original sha: 9f9567c
* Authored by spalger <spalger@users.noreply.github.com> on 2017-01-17T19:49:39Z
This was referenced Jan 17, 2017
Merged
Merged
elastic-jasper added a commit that referenced this pull request Jan 17, 2017
@elastic-jasper
Hide time navigation buttons
3f169a3 
Backports PR #9909

**Commit 1:**
[ui/timepicker] hide time navigation buttons for now

* Original sha: 9f9567c
* Authored by spalger <spalger@users.noreply.github.com> on 2017-01-17T19:49:39Z
@tbragin
Copy link
Contributor

tbragin commented Jan 17, 2017

@lukasolson The PR for automatically closing the timepicker (#9618) went into 5.3, not 5.2 as far as I know. So if the plan is to fix issues with Prev/Next navigation and still get it into 5.3, I think we should not revert until we know what that plan is.

spalger pushed a commit that referenced this pull request Jan 17, 2017
@elastic-jasper @spalger
Hide time navigation buttons (#9913)
e211bd1 
Backports PR #9909

**Commit 1:**
[ui/timepicker] hide time navigation buttons for now

* Original sha: 9f9567c
* Authored by spalger <spalger@users.noreply.github.com> on 2017-01-17T19:49:39Z
spalger pushed a commit that referenced this pull request Jan 17, 2017
@elastic-jasper @spalger
Hide time navigation buttons (#9914)
47d3f82 
Backports PR #9909

**Commit 1:**
[ui/timepicker] hide time navigation buttons for now

* Original sha: 9f9567c
* Authored by spalger <spalger@users.noreply.github.com> on 2017-01-17T19:49:39Z
@epixa epixa removed the v6.0.0 label Feb 7, 2017
@spalger spalger deleted the hide/time-navigation branch October 18, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasolson lukasolson lukasolson approved these changes

Assignees

@lukasolson lukasolson

Labels

review v5.2.0 v5.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spalger @uboness @lukasolson @tbragin @epixa