Skip to content

[Fleet] Make security rules package optional (revert #97191)#98854

Merged
rw-access merged 1 commit intoelastic:masterfrom
rw-access:partial-revert-97191
Apr 30, 2021
Merged

[Fleet] Make security rules package optional (revert #97191)#98854
rw-access merged 1 commit intoelastic:masterfrom
rw-access:partial-revert-97191

Conversation

@rw-access
Copy link
Copy Markdown
Contributor

Summary

Per some conversations with PM, the security_detection_engine package will be optional in 7.13.
This reverts the relevant parts of #97191. (Doesn't revert the updated dependencies)

@rw-access rw-access added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.13.1 labels Apr 30, 2021
@rw-access rw-access requested a review from a team as a code owner April 30, 2021 00:01
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Feature:EPM)

@rw-access rw-access changed the title [Fleet] Make security rules optional (revert #97191) [Fleet] Make security rules packagee optional (revert #97191) Apr 30, 2021
@rw-access rw-access changed the title [Fleet] Make security rules packagee optional (revert #97191) [Fleet] Make security rules package optional (revert #97191) Apr 30, 2021
Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
globalSearch 13 - -13
reporting 130 - -130
total -143

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
reporting 1 - -1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
globalSearch 6 - -6
reporting 18 - -18
total -24

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 346.8KB 346.7KB -52.0B
Unknown metric groups

API count

id before after diff
globalSearch 67 - -67
reporting 131 - -131
total -198

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 30, 2021
Co-authored-by: Ross Wolf <31489089+rw-access@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Apr 30, 2021
Co-authored-by: Ross Wolf <31489089+rw-access@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v7.13.1 v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants