Skip to content

[Canvas] Fix column object shape in datatable created by CSV function#98561

Merged
cqliu1 merged 4 commits intoelastic:masterfrom
cqliu1:fix/csv-function
May 17, 2021
Merged

[Canvas] Fix column object shape in datatable created by CSV function#98561
cqliu1 merged 4 commits intoelastic:masterfrom
cqliu1:fix/csv-function

Conversation

@cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Apr 27, 2021

Summary

The CSV function broke with the changes to the shape of a datatable column object that added meta data. This fixes the CSV to create a new column with the correct meta data.

For maintainers

@cqliu1 cqliu1 added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort v8.0.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Canvas v7.14.0 v7.13.0 labels Apr 27, 2021
@cqliu1 cqliu1 requested a review from a team as a code owner April 27, 2021 23:43
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 27, 2021

Pinging @elastic/kibana-presentation (Team:Presentation)

@kmartastic
Copy link
Contributor

kmartastic commented Apr 29, 2021

@cqliu1 can this fix be back-ported?

crob611
crob611 approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cqliu1 cqliu1 added v7.13.1 and removed v7.13.1 labels May 17, 2021
@cqliu1
Copy link
Contributor Author

cqliu1 commented May 17, 2021

@kmartastic I was planning to backport it to 7.13, but I think it might impact Kibana 7.10+. How far back did you want it backported?

@cqliu1
Copy link
Contributor Author

cqliu1 commented May 17, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented May 17, 2021

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 534.1KB 534.1KB +25.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -295

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit 49b1ccd into elastic:master May 17, 2021
@cqliu1 cqliu1 deleted the fix/csv-function branch May 17, 2021 16:45
This was referenced May 17, 2021
Merged
Merged
cqliu1 added a commit to cqliu1/kibana that referenced this pull request May 17, 2021
@cqliu1 @kibanamachine
[Canvas] Fix column object shape in datatable created by CSV function (…
1499663 
…elastic#98561)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cqliu1 added a commit to cqliu1/kibana that referenced this pull request May 17, 2021
@cqliu1 @kibanamachine
[Canvas] Fix column object shape in datatable created by CSV function (…
14e332b 
…elastic#98561)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cqliu1 added a commit that referenced this pull request May 17, 2021
@cqliu1 @kibanamachine
[Canvas] Fix column object shape in datatable created by CSV function (…
2bb2fc2 
…#98561) (#100225)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cqliu1 added a commit that referenced this pull request May 17, 2021
@cqliu1 @kibanamachine
[Canvas] Fix column object shape in datatable created by CSV function (…
b998650 
…#98561) (#100226)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kmartastic
Copy link
Contributor

kmartastic commented May 17, 2021

I'm not sure how much work it is, but at a minimum going back to the current public release (7.12).

Thoughts @timductive or @clintandrewhall ?

@wylieconlon wylieconlon mentioned this pull request May 18, 2021
Merged
1 task
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@cqliu1 @kibanamachine @yctercero
[Canvas] Fix column object shape in datatable created by CSV function (…
28fd918 
…elastic#98561)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@crob611 crob611 crob611 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.13.0 v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cqliu1 @elasticmachine @kmartastic @kibanamachine @crob611