Skip to content

[File Data Visualizer] Fixing missing css imports for file stats table#98312

Merged
jgowdyelastic merged 3 commits intoelastic:masterfrom
jgowdyelastic:fixing-file-data-visuailzer-file-stats-table-styles
Apr 27, 2021
Merged

[File Data Visualizer] Fixing missing css imports for file stats table#98312
jgowdyelastic merged 3 commits intoelastic:masterfrom
jgowdyelastic:fixing-file-data-visuailzer-file-stats-table-styles

Conversation

@jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Apr 26, 2021

Adds css imports which were missed in #96408
Also adds a functional test for opening the generated filebeat config.

These changes were originally added in #98264, but needed to be separated out into their own PR.

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer v7.14.0 v7.13.0 labels Apr 26, 2021
@jgowdyelastic jgowdyelastic self-assigned this Apr 26, 2021
@jgowdyelastic jgowdyelastic requested review from a team as code owners April 26, 2021 15:12
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member

qn895 commented Apr 26, 2021

Tested and LGTM 🎉

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM
The functional test will/should fail until the security issue is fixed.

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fileDataVisualizer 1.0MB 1.0MB +7.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 27, 2021
@jgowdyelastic jgowdyelastic merged commit c983283 into elastic:master Apr 27, 2021
@jgowdyelastic jgowdyelastic deleted the fixing-file-data-visuailzer-file-stats-table-styles branch April 27, 2021 10:16
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2021
elastic#98312)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2021
elastic#98312)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 27, 2021
#98312) (#98459)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Apr 27, 2021
#98312) (#98458)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: James Gowdy <jgowdy@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:File and Index Data Viz ML file and index data visualizer :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.13.0 v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants