Skip to content

Expose authc on public start contract#98307

Merged
legrego merged 2 commits intoelastic:masterfrom
legrego:security/public-authc-start
Apr 26, 2021
Merged

Expose authc on public start contract#98307
legrego merged 2 commits intoelastic:masterfrom
legrego:security/public-authc-start

Conversation

@legrego
Copy link
Member

@legrego legrego commented Apr 26, 2021 •
edited
Loading

Summary

Exposes the security plugins authc service on the public start contract.

Requested via #98264 (review)

@legrego legrego added chore Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 26, 2021
legrego
legrego commented Apr 26, 2021
View reviewed changes
x-pack/plugins/security/public/plugin.tsx
return { navControlService: this.navControlService.start({ core }) };
return {
navControlService: this.navControlService.start({ core }),
authc: this.authc as AuthenticationServiceStart,
Copy link
Member Author

@legrego legrego Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative is to give the authorization service a real start lifecycle method so that it can expose these functions itself.

At this point, we have no need for a real start lifecycle, so this is the easier approach.

@legrego legrego mentioned this pull request Apr 26, 2021
Closed
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 26, 2021

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
security 124.4KB 124.5KB +17.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego marked this pull request as ready for review April 26, 2021 17:11
@legrego legrego requested a review from a team as a code owner April 26, 2021 17:11
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 26, 2021

Pinging @elastic/kibana-security (Team:Security)

jportner
jportner approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this and the linked PR are labeled with v7.13.0, it looks like that's intentional but I just wanted to point it out before the backport happens in case it wasn't!

@legrego
Copy link
Member Author

legrego commented Apr 26, 2021

I see this and the linked PR are labeled with v7.13.0, it looks like that's intentional but I just wanted to point it out before the backport happens in case it wasn't!

Yes, this is an intentional backport to 7.13.0 - thanks for double checking!

@legrego legrego merged commit 5e55f43 into elastic:master Apr 26, 2021
@legrego legrego deleted the security/public-authc-start branch April 26, 2021 19:59
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 26, 2021
@legrego @kibanamachine
Expose authc on public start contract (elastic#98307)
229357f 
* Expose authc on public start contract

* fix mock
@kibanamachine kibanamachine mentioned this pull request Apr 26, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 26, 2021
@legrego @kibanamachine
Expose authc on public start contract (elastic#98307)
fd8bd3d 
* Expose authc on public start contract

* fix mock
@kibanamachine kibanamachine mentioned this pull request Apr 26, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 26, 2021

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 26, 2021
@kibanamachine @legrego
Expose authc on public start contract (#98307) (#98374)
438144b 
* Expose authc on public start contract

* fix mock

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
kibanamachine added a commit that referenced this pull request Apr 26, 2021
@kibanamachine @legrego
Expose authc on public start contract (#98307) (#98375)
041d6cb 
* Expose authc on public start contract

* fix mock

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jportner jportner jportner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.13.0 v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legrego @kibanamachine @elasticmachine @jportner