Skip to content

[ML] Anomaly detection explorer: ensure user can change number of rows in the anomalies table #98232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alvarezmelissa87 wants to merge 2 commits into from
Closed

[ML] Anomaly detection explorer: ensure user can change number of rows in the anomalies table #98232

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d511c4
ensure page update works
alvarezmelissa87 Apr 23, 2021
6d9f73e
Merge branch 'master' into ml-dfa-table-page-fix
kibanamachine Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions x-pack/plugins/ml/public/application/components/anomalies_table/anomalies_table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,12 @@ export class AnomaliesTableInternal extends Component {
};

onTableChange = ({ page, sort }) => {
const pageCopy = { ...page };
const { tableState, updateTableState } = this.props;
const result = {
pageIndex: page && page.index !== undefined ? page.index : tableState.pageIndex,
pageSize: page && page.size !== undefined ? page.size : tableState.pageSize,
sortField: sort && sort.field !== undefined ? sort.field : tableState.sortField,
pageIndex: page && page.index !== undefined ? pageCopy.index : tableState.pageIndex,
pageSize: page && page.size !== undefined ? pageCopy.size : tableState.pageSize,
sortField: sort && sort.field !== undefined ? pageCopy.field : tableState.sortField,

@darnautov darnautov Apr 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual problem is with sortField and changes in your PR replace it with pageCopy.field which is always undefined because the updates come from the sort property. Check #98270 for more details.

Also important to note, in JavaScript, numbers and strings are not a reference type, hence creatingpageCopy doesn't affect anything, because we access index and size by value at all times.

sortDirection:
sort && sort.direction !== undefined ? sort.direction : tableState.sortDirection,
};
Expand Down