Skip to content

[ML] removing unused notification settings endpoint#98109

Merged
jgowdyelastic merged 4 commits intoelastic:masterfrom
jgowdyelastic:removing-unused-notification-settings-endpoint
Apr 23, 2021
Merged

[ML] removing unused notification settings endpoint#98109
jgowdyelastic merged 4 commits intoelastic:masterfrom
jgowdyelastic:removing-unused-notification-settings-endpoint

Conversation

@jgowdyelastic
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic commented Apr 23, 2021 •
edited
Loading

Endpoint originally used by our watcher integration, is no longer used after this PR #91283

This was referenced Apr 23, 2021
Closed
Closed
@jgowdyelastic jgowdyelastic self-assigned this Apr 23, 2021
@jgowdyelastic jgowdyelastic added :ml auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.13.0 v7.14.0 v8.0.0 labels Apr 23, 2021
@jgowdyelastic jgowdyelastic marked this pull request as ready for review April 23, 2021 10:05
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 23, 2021 10:05
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 23, 2021

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darnautov
darnautov approved these changes Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 23, 2021 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit bda0a93 into elastic:master Apr 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 23, 2021
@jgowdyelastic @kibanamachine
[ML] removing unused notification settings endpoint (elastic#98109)
107d02c 
* [ML] removing unused notification settings endpoint

* removing route init function

* test commit

* removing test comment
@kibanamachine kibanamachine mentioned this pull request Apr 23, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 23, 2021
@jgowdyelastic @kibanamachine
[ML] removing unused notification settings endpoint (elastic#98109)
71b4fa9 
* [ML] removing unused notification settings endpoint

* removing route init function

* test commit

* removing test comment
@kibanamachine kibanamachine mentioned this pull request Apr 23, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 23, 2021

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 23, 2021
@kibanamachine @jgowdyelastic
[ML] removing unused notification settings endpoint (#98109) (#98132)
62d1464 
* [ML] removing unused notification settings endpoint

* removing route init function

* test commit

* removing test comment

Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Apr 23, 2021
@kibanamachine @jgowdyelastic
[ML] removing unused notification settings endpoint (#98109) (#98133)
7cda60c 
* [ML] removing unused notification settings endpoint

* removing route init function

* test commit

* removing test comment

Co-authored-by: James Gowdy <jgowdy@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darnautov darnautov darnautov approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.13.0 v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jgowdyelastic @elasticmachine @kibanamachine @darnautov @peteharverson