Skip to content

[Canvas] Hide global banner list in fullscreen mode#98058

Merged
cqliu1 merged 1 commit intoelastic:masterfrom
cqliu1:canvas/fullscreen-hide-banners
Apr 23, 2021
Merged

[Canvas] Hide global banner list in fullscreen mode#98058
cqliu1 merged 1 commit intoelastic:masterfrom
cqliu1:canvas/fullscreen-hide-banners

Conversation

@cqliu1
Copy link
Copy Markdown
Contributor

@cqliu1 cqliu1 commented Apr 22, 2021

Summary

Fixes #59697.

This hides the global banner list when you're in fullscreen mode in Canvas.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cqliu1 cqliu1 added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Canvas v7.14.0 labels Apr 22, 2021
@cqliu1 cqliu1 requested a review from a team as a code owner April 22, 2021 17:10
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 22, 2021

Pinging @elastic/kibana-presentation (Team:Presentation)

@cqliu1 cqliu1 added the loe:small Small Level of Effort label Apr 22, 2021
@spalger
Copy link
Copy Markdown
Contributor

spalger commented Apr 22, 2021

jenkins, test this (necessary for Jenkins update)

ryankeairns
ryankeairns approved these changes Apr 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks heavy at first glance :) , but it's just for fullscreen mode.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 22, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.2MB 1.2MB +224.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit bf4b6d2 into elastic:master Apr 23, 2021
@cqliu1 cqliu1 deleted the canvas/fullscreen-hide-banners branch April 23, 2021 18:07
@cqliu1 cqliu1 added the v7.13.0 label Apr 23, 2021
@cqliu1 cqliu1 mentioned this pull request Apr 23, 2021
Merged
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Apr 23, 2021
@cqliu1
[Canvas] Hide global banner list in fullscreen mode (elastic#98058)
94d4152
cqliu1 added a commit that referenced this pull request Apr 23, 2021
@cqliu1
[Canvas] Hide global banner list in fullscreen mode (#98058) (#98201)
5ab8f22
@cqliu1 cqliu1 restored the canvas/fullscreen-hide-banners branch June 8, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees

No one assigned

Labels

bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.13.0 v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Canvas] Telemetry Notification Shows in Full Screen

5 participants

@cqliu1 @elasticmachine @spalger @kibanamachine @ryankeairns