Log instead of throwing error when alert type doesn't exist#98005
Merged
mikecote merged 3 commits intoelastic:masterfrom Apr 23, 2021
Merged
Log instead of throwing error when alert type doesn't exist#98005mikecote merged 3 commits intoelastic:masterfrom
mikecote merged 3 commits intoelastic:masterfrom
Conversation
mikecote
added
Feature:Alerting
v8.0.0
release_note:skip
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @mikecote |
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
ymao1
approved these changes
Apr 22, 2021
Contributor
ymao1
left a comment
ymao1
left a comment
There was a problem hiding this comment.
LGTM. Commented out an alert type on the server and verified it was console logged with no error thrown.
mikecote
added
the
auto-backport
Contributor
💔 Backport failed
To backport manually run: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Apr 23, 2021
…98005) * Log instead of throwing error when alert type doesn't exist * Cleanup i18n * Update error messages # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
mikecote
added a commit
that referenced
this pull request
Apr 23, 2021
…98121) * Log instead of throwing error when alert type doesn't exist * Cleanup i18n * Update error messages # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been reports (#59229 (comment)) that our alerting public plugin throws unhandled errors. This PR removes the throwing and replaces it with a console log.