Skip to content

[Cloud plugin] Added README text#97999

Merged
yuliacech merged 5 commits intoelastic:masterfrom
yuliacech:cloud_readme
Apr 23, 2021
Merged

[Cloud plugin] Added README text#97999
yuliacech merged 5 commits intoelastic:masterfrom
yuliacech:cloud_readme

Conversation

@yuliacech
Copy link
Copy Markdown
Contributor

Summary

Recently, several new values have been added to Cloud plugin #95569. This PR adds information about those values that Cloud plugin now supplies.
I gathered information from #95569 and cloud#77420 and tried to describe the values how I understand them, change suggestions are welcome.

@yuliacech yuliacech added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.0.0 v7.14.0 labels Apr 22, 2021
@yuliacech yuliacech requested a review from ryankeairns April 22, 2021 12:46
@yuliacech yuliacech requested a review from a team as a code owner April 22, 2021 12:46
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-core (Team:Core)

@yuliacech yuliacech added the release_note:skip Skip the PR/issue when compiling release notes label Apr 22, 2021
Copy link
Copy Markdown
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found 1 typo 😇

Comment thread x-pack/plugins/cloud/README.md Outdated
Comment thread x-pack/plugins/cloud/README.md Outdated
# `cloud` plugin

The `cloud` plugin adds cloud specific features to Kibana.
The plugin configures following values:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: The list below looks like it's the Public setup contract. The Server-side contract is slightly different.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, @afharo! I haven't thought about the server-side and never used it before, so I added 'client-side' to the text.

yuliacech and others added 2 commits April 22, 2021 15:40
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Copy link
Copy Markdown
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuliacech you might need to run node scripts/build_plugin_list_docs and commit the changes to get a green CI :)

@yuliacech
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech yuliacech merged commit 5d0af1c into elastic:master Apr 23, 2021
yuliacech added a commit that referenced this pull request Apr 26, 2021
* Added README text

* Update x-pack/plugins/cloud/README.md

Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>

* Updated README.md

* Updated docs build

Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@yuliacech yuliacech deleted the cloud_readme branch May 10, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeededFor:Cloud release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants