Skip to content

[Lens] Make Lens report internal code errors correctly#97980

Merged
dej611 merged 1 commit intoelastic:masterfrom
dej611:fix/lens-error-bubbling
Apr 23, 2021
Merged

[Lens] Make Lens report internal code errors correctly#97980
dej611 merged 1 commit intoelastic:masterfrom
dej611:fix/lens-error-bubbling

Conversation

@dej611
Copy link
Copy Markdown
Contributor

@dej611 dej611 commented Apr 22, 2021

Summary

when investigating another bug I noticed JS errors were not bubbling up correctly in the workspace correctly, due to some changes in #96611 .

This fix gives priority to network/ES/esaggs errors when available, then internal JS ones, without hiding them.

@dej611 dej611 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 22, 2021
@dej611 dej611 requested a review from a team April 22, 2021 10:54
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 22, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293
flash1293 approved these changes Apr 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 22, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 948.5KB 948.6KB +76.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 0423e7d into elastic:master Apr 23, 2021
@dej611 dej611 deleted the fix/lens-error-bubbling branch April 23, 2021 09:07
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 23, 2021
@dej611 @kibanamachine
[Lens] Make Lens report internal code errors correctly (elastic#97980)
d0fd861
@kibanamachine kibanamachine mentioned this pull request Apr 23, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 23, 2021
@dej611 @kibanamachine
[Lens] Make Lens report internal code errors correctly (elastic#97980)
68a61ae
@kibanamachine kibanamachine mentioned this pull request Apr 23, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 23, 2021

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 23, 2021
@kibanamachine @dej611
[Lens] Make Lens report internal code errors correctly (#97980) (#98105)
a2f386b 
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Apr 23, 2021
@kibanamachine @dej611
[Lens] Make Lens report internal code errors correctly (#97980) (#98106)
ac14672 
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.13.0 v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dej611 @elasticmachine @kibanamachine @flash1293