Skip to content

Improve Discover table preview usability. #9798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjcenizal wants to merge 3 commits into from
Closed

Improve Discover table preview usability. #9798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d06377a
Improve Discover table preview usability.
cjcenizal Dec 23, 2016
dfc749f
Truncate document details instead of allowing scrolling.
cjcenizal Jan 7, 2017
156f127
Align top of source item cell with timestamp cell
weltenwort Jan 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/core_plugins/kibana/public/discover/styles/main.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,6 @@
overflow-x: auto;
padding-left: 0px !important;
padding-right: 0px !important;

tbody {
font-family: "Lucida Console", Monaco, monospace;
}
}

.discover-table-footer {
Expand Down
3 changes: 2 additions & 1 deletion src/ui/public/doc_table/components/table_row.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const MIN_LINE_LENGTH = 20;
module.directive('kbnTableRow', function ($compile) {
const cellTemplate = _.template(noWhiteSpace(require('ui/doc_table/components/table_row/cell.html')));
const truncateByHeightTemplate = _.template(noWhiteSpace(require('ui/partials/truncate_by_height.html')));
const cellDetailsTemplate = _.template(noWhiteSpace(require('ui/doc_table/components/table_row/document_details.html')));

return {
restrict: 'A',
Expand Down Expand Up @@ -151,7 +152,7 @@ module.directive('kbnTableRow', function ($compile) {
const text = indexPattern.formatField(row, fieldName);

if (truncate && text.length > MIN_LINE_LENGTH) {
return truncateByHeightTemplate({
return cellDetailsTemplate({
body: text
});
}
Expand Down
3 changes: 3 additions & 0 deletions src/ui/public/doc_table/components/table_row/document_details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<div class="kuiDocumentDetails">
<%= body %>
</div>
45 changes: 45 additions & 0 deletions src/ui/public/doc_table/doc_table.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,48 @@ doc-table {
opacity: @loading-opacity;
}
}

.kuiDocumentDetails {
display: flex;
max-height: 100px;
overflow-x: hidden;
overflow-y: hidden;

&::-webkit-scrollbar {
width: 16px;
height: 16px;
}

&::-webkit-scrollbar-thumb {
background-color: #ecf0f1;
border: 6px solid transparent;
background-clip: content-box;
}

&::-webkit-scrollbar-track {
background-color: transparent;
}
}

.kuiDocumentSource {
display: flex;
flex-direction: column;
flex-wrap: wrap;
margin-top: -4px;
}

.kuiDocumentSourceItem {
width: 300px;
padding: 4px 2px 0;
margin-right: 2px;
}

.kuiDocumentSourceItem__term {
word-wrap: break-word;
font-weight: bold;
}

.kuiDocumentSourceItem__description {
word-wrap: break-word;
padding-bottom: 4px;
}
10 changes: 6 additions & 4 deletions src/ui/public/stringify/types/_source.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<dl class="source truncate-by-height">
<div class="source kuiDocumentSource">
<% defPairs.forEach(function (def) { %>
<dt><%- def[0] %>:</dt>
<dd><%= def[1] %></dd>
<div class="kuiDocumentSourceItem">
<div class="kuiDocumentSourceItem__term"><%- def[0] %></div>
<div class="kuiDocumentSourceItem__description"><%= def[1] %></div>
</div>
<%= ' ' %>
<% }); %>
</dl>
</div>
221 changes: 0 additions & 221 deletions src/ui/public/styles/base.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,225 +919,4 @@ fieldset {
}
}


// TODO: Extract these styles into the UI Framework.

.kuiFormSection {
margin-bottom: 16px;
}

.kuiFormLabel {
display: block;
}

.kuiFormSubLabel {
display: block;
font-weight: normal;
}

.kuiTextArea,
.kuiInput,
.kuiStaticInput {
display: block;
width: 100%;
font-size: 14px;
color: #2d2d2d;
border: 1px solid;
border-radius: 4px;
}

.kuiStaticInput {
padding: 5px 0;
border-color: transparent;
}

.kuiInput,
.kuiTextArea {
padding: 5px 15px;
border-color: #D4D4D4;
}

.kuiSelect {
display: block;
width: 100%;
height: 32px;
padding: 5px 15px;
font-size: 14px;
line-height: 1.42857143;
color: #2D2D2D;
background-color: #ffffff;
background-image: none;
border: 1px solid #D4D4D4;
border-radius: 4px;
}

/**
* 1. Override Bootstrap checkbox styles.
*/
.kuiCheckBox {
margin: 0 !important; // 1
}

.kuiSideBarSelect {
// TODO: @include kuiSelect styles when this is moved to the UI Framework and we're using SASS.
height: 24px;
font-size: 12px;
padding: 0 15px;
}

.kuiSideBarInput {
// TODO: @include kuiInput styles when this is moved to the UI Framework and we're using SASS.
height: 24px;
font-size: 12px;
}

.kuiSideBarSection {
margin-bottom: 6px;
}

.kuiSideBarSectionTitle {
display: flex;
justify-content: space-between;
align-items: center;
margin-bottom: 6px;
border-bottom: 1px solid #D4D4D4;
}

.kuiSideBarSectionTitle__text {
font-size: 14px;
font-weight: 700;
color: #5A5A5A;
}

/**
* 1. Override Bootstrap button styles.
*/
.kuiSideBarSectionTitle__action {
background-color: transparent; // 1
padding: 0; // 1
cursor: pointer;
color: #328CAA;

&:hover {
color: #105A73;
}
}

.kuiSideBarCollapsibleTitle {
display: flex;
align-items: center;
justify-content: space-between;
width: 100%;
margin-bottom: 4px;
border-bottom: 1px solid #E8E8E8;
}

.kuiSideBarCollapsibleTitle__label {
display: flex;
align-items: center;
}

/**
* 1. Override FontAwesome .fa styles.
*/
.kuiSideBarCollapsibleTitle__caret {
width: 12px;
height: 12px;
font-size: 12px !important; // 1
font-weight: 700;
color: #5A5A5A;
}

.kuiSideBarCollapsibleTitle__text {
font-size: 12px;
font-weight: 700;
color: #5A5A5A;
}

/**
* 1. Override Bootstrap button styles.
*/
.kuiSideBarCollapsibleTitle__action {
background-color: transparent; // 1
padding: 0; // 1
cursor: pointer;
color: #328CAA;

&:hover {
color: #105A73;
}
}

.kuiSideBarCollapsibleSection {
padding-left: 16px;
}

/**
* 1. Override Bootstrap h1 styles.
*/
.kuiSideBarFormSectionTitle {
font-size: 12px;
font-weight: 700;
color: #5A5A5A;
border-bottom: 1px solid #E8E8E8;
margin: 4px 0 !important; // 1
padding-bottom: 2px;
}

.kuiSideBarFormRow {
display: flex;
align-items: center;
min-height: 24px;
margin-bottom: 1px;
}

/**
* 1. Override .vis-editor-sidebar styles.
*/
.kuiSideBarFormRow__label {
display: flex;
align-items: center;
flex: 1 1 40% !important; // 1
font-weight: 400;
}

.kuiSideBarFormRow__label__colorbox {
width: 24px;
height: 24px;
display: inline-block;
margin-right: 10px;
border: 1px ridge lightgray;
}

.kuiSideBarFormRow__control {
display: flex;
align-items: center;
flex: 1 1 60%;
}

/**
* 1. Override .sidebar-item styles.
*/
.kuiSideBarOptionsLink {
display: flex;
align-items: baseline;
margin-bottom: 8px;
font-size: 12px;
color: #328CAA !important; // 1

&:hover {
color: #105A73 !important; // 1
}
}

.kuiSideBarOptionsLink__caret {
width: 10px;
height: 10px;
}

.kuiSideBarOptionsLink__text {
margin-left: 2px;
}


@import "~dragula/dist/dragula.css";