Skip to content

[ML] Add tooltip for interval in Anomaly Explorer#97944

Merged
lcawl merged 2 commits intoelastic:masterfrom
lcawl:interval-tooltips
Apr 23, 2021
Merged

[ML] Add tooltip for interval in Anomaly Explorer#97944
lcawl merged 2 commits intoelastic:masterfrom
lcawl:interval-tooltips

Conversation

@lcawl
Copy link
Copy Markdown
Contributor

@lcawl lcawl commented Apr 22, 2021

Summary

This PR adds a tooltip for the "Interval" selector in the Anomaly Explorer.

image

@lcawl lcawl added enhancement New value added to drive a business result :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Apr 22, 2021
@lcawl lcawl requested a review from a team as a code owner April 22, 2021 01:18
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

<EuiToolTip
content={i18n.translate('xpack.ml.explorer.intervalTooltip', {
defaultMessage:
'Show all anomalies or only the highest severity anomaly for each hour or day.',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth trying to explain what the auto value? (Shows by hour or day depending on the selected time span - uses hour if less than 2 days selected, otherwise uses day).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that the detail of auto is needed.

One observation ... it is a better experience if you summarise your anomalies, hence the default is either hr/day. By leading with "Show all" are we encouraging "Show all"? .. because we should be encouraging to view as summarised.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I've altered the text in 709de27

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +548.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited text LGTM.

Is it worth adding this tooltip into the Single Metric Viewer as part of this PR? If so, I think you just need to add this same code into ml/public/application/timeseriesexplorer/timeseriesexplorer.js

@lcawl
Copy link
Copy Markdown
Contributor Author

lcawl commented Apr 23, 2021

Is it worth adding this tooltip into the Single Metric Viewer as part of this PR?

Good point! I've created #98174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cosmetic enhancement New value added to drive a business result Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants