[Security solution][Endpoint] New Event Filters sub-section under Administration area#97903
Conversation
…t-filters-list-view
paul-tavares
added
v8.0.0
release_note:skip
…t-filters-list-view
| <div> | ||
| <EuiSpacer size="l" /> | ||
|
|
||
| <EuiTablePagination |
There was a problem hiding this comment.
out of curiosity - Is there an specific reason why you are using this instead of EuiPagination
There was a problem hiding this comment.
I just copied it from Trusted apps. I looked at EuiPagination, but it only gives you the pagination portion, not the items per page dropdown. Late yesterday I noticed that we don't have control over the label on the "Pick page Size" dropdown and that the label being used now ("Items per row") is a bit specific to tables and we might want this component to allow control of it.
What do you think? create a custom pagination component for use by this PaginatedContent component?
There was a problem hiding this comment.
Oh, I see... What about a custom component with EuiPagination and a dropdown for page size?
There was a problem hiding this comment.
Something like this: https://elastic.github.io/eui/#/navigation/pagination#customizable-pagination
There was a problem hiding this comment.
Yeah, I think that will likely be better and will decouple us from the Pagination component used in Tables.
I will include that change in next PR that will follow this one
Thanks for the feedback.
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| type ComponentWithAnyProps = ComponentType<any>; | ||
|
|
||
| export interface PaginatedContentProps<T, C extends ComponentWithAnyProps> { |
There was a problem hiding this comment.
This component will allow us to reuse a lot of code between trusted apps, event filters and upcoming listings 👍 😃
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
|
LGTM!! 🔥 🚢 🥳 |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
…inistration area (elastic#97903) * Add Event Filters section to the Admin area (behind feature flag) * new `PaginatedContent` generic component * Refactor Trusted Apps grid view to use PaginatedContent * Refactor usages of `getTestId()` to use new hook
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…inistration area (#97903) (#98169) * Add Event Filters section to the Admin area (behind feature flag) * new `PaginatedContent` generic component * Refactor Trusted Apps grid view to use PaginatedContent * Refactor usages of `getTestId()` to use new hook Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
4 participants
Summary
eventFilteringEnabledexperimental feature)itemin the content will be rendered using a Component that is also defined as a prop.Checklist
Delete any items that are not applicable to this PR.