Skip to content

[ML] API Integration tests: adds test for Data Frame Analytics evaluate endpoint#97856

Merged
alvarezmelissa87 merged 6 commits intoelastic:masterfrom
alvarezmelissa87:ml-dfa-evaluate-api-test
Apr 23, 2021
Merged

[ML] API Integration tests: adds test for Data Frame Analytics evaluate endpoint#97856
alvarezmelissa87 merged 6 commits intoelastic:masterfrom
alvarezmelissa87:ml-dfa-evaluate-api-test

Conversation

@alvarezmelissa87
Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Apr 21, 2021

Summary

Part of meta issue #93205
Tests evaluate endpoint for regression and classification jobs.

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.13.0 labels Apr 21, 2021
@alvarezmelissa87 alvarezmelissa87 requested a review from pheyos April 21, 2021 17:07
@alvarezmelissa87 alvarezmelissa87 self-assigned this Apr 21, 2021
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner April 21, 2021 17:07
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

@spalger spalger added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
@darnautov darnautov added v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 22, 2021
Copy link
Copy Markdown
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see these tests coming! 🎉
Just one nit and a suggestion.

eval: any;
}

const testJobConfigs: TestConfig[] = ['regression', 'classification'].map((jobType, idx) => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: idx isn't used, so could be removed here.

@alvarezmelissa87 alvarezmelissa87 requested a review from qn895 April 22, 2021 16:15
Copy link
Copy Markdown
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Apr 22, 2021

jenkins, test this (necessary for Jenkins update)

@alvarezmelissa87
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@qn895
Copy link
Copy Markdown
Member

qn895 commented Apr 23, 2021

LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit d6e0251 into elastic:master Apr 23, 2021
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Apr 23, 2021
…te endpoint (elastic#97856)

* wip: add api test for evaluate endpoint

* Add api test for evaluate endpoint

* add tests for view only and unauthorized user

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 23, 2021
…te endpoint (elastic#97856)

* wip: add api test for evaluate endpoint

* Add api test for evaluate endpoint

* add tests for view only and unauthorized user

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Apr 23, 2021
…te endpoint (elastic#97856)

* wip: add api test for evaluate endpoint

* Add api test for evaluate endpoint

* add tests for view only and unauthorized user

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 23, 2021
…te endpoint (elastic#97856)

* wip: add api test for evaluate endpoint

* Add api test for evaluate endpoint

* add tests for view only and unauthorized user

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-evaluate-api-test branch April 23, 2021 16:53
kibanamachine added a commit that referenced this pull request Apr 23, 2021
…te endpoint (#97856) (#98183)

* wip: add api test for evaluate endpoint

* Add api test for evaluate endpoint

* add tests for view only and unauthorized user

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Melissa Alvarez <melissa.alvarez@elastic.co>
alvarezmelissa87 added a commit that referenced this pull request Apr 23, 2021
…te endpoint (#97856) (#98182)

* wip: add api test for evaluate endpoint

* Add api test for evaluate endpoint

* add tests for view only and unauthorized user

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alvarezmelissa87 added a commit that referenced this pull request Apr 23, 2021
…te endpoint (#97856) (#98181)

* wip: add api test for evaluate endpoint

* Add api test for evaluate endpoint

* add tests for view only and unauthorized user

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Apr 23, 2021
…te endpoint (#97856) (#98184)

* wip: add api test for evaluate endpoint

* Add api test for evaluate endpoint

* add tests for view only and unauthorized user

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Melissa Alvarez <melissa.alvarez@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.13.0 v7.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants