Skip to content

[ML] Fixing categorization job wizard with CCS#97855

Merged
jgowdyelastic merged 7 commits intoelastic:masterfrom
jgowdyelastic:fixing-categorization-job-wizard-with-ccs
Apr 23, 2021
Merged

[ML] Fixing categorization job wizard with CCS#97855
jgowdyelastic merged 7 commits intoelastic:masterfrom
jgowdyelastic:fixing-categorization-job-wizard-with-ccs

Conversation

@jgowdyelastic
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic commented Apr 21, 2021

If the categorisation examples check fails to find any examples we now also check to see whether the selected index pattern is cross-cluster. If so, a warning is displayed to inform the user that one of the clusters may be an incompatible version for this check and the user is allowed to proceed in the wizard

image

Fixes #94737

@jgowdyelastic jgowdyelastic self-assigned this Apr 22, 2021
@jgowdyelastic jgowdyelastic added :ml bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection release_note:fix auto-backport Deprecated - use backport:version if exact versions are needed v7.13.0 v7.14.0 v8.0.0 labels Apr 22, 2021
@jgowdyelastic jgowdyelastic marked this pull request as ready for review April 22, 2021 08:59
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 22, 2021 08:59
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment, but otherwise LGTM

Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jgowdyelastic
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1736 1737 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +2.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 1b1d98b into elastic:master Apr 23, 2021
@jgowdyelastic jgowdyelastic deleted the fixing-categorization-job-wizard-with-ccs branch April 23, 2021 13:10
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 23, 2021
* [ML] Fixing categorization job wizard with CCS

* adding comment

* switching logic around

* updating text

* moving ccs check to util function

* fixing jest test mock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 23, 2021
* [ML] Fixing categorization job wizard with CCS

* adding comment

* switching logic around

* updating text

* moving ccs check to util function

* fixing jest test mock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 23, 2021
* [ML] Fixing categorization job wizard with CCS

* adding comment

* switching logic around

* updating text

* moving ccs check to util function

* fixing jest test mock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Apr 23, 2021
* [ML] Fixing categorization job wizard with CCS

* adding comment

* switching logic around

* updating text

* moving ccs check to util function

* fixing jest test mock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: James Gowdy <jgowdy@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.13.0 v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ML] Categorization validation failed if source index is from a remote CCS 6.8 cluster

5 participants