Skip to content

[License Management] Migrate to new ES client#97795

Merged
jloleysens merged 2 commits intoelastic:masterfrom
jloleysens:license-management/migrate-legacy-es-client
Apr 23, 2021
Merged

[License Management] Migrate to new ES client#97795
jloleysens merged 2 commits intoelastic:masterfrom
jloleysens:license-management/migrate-legacy-es-client

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

Summary

See #73973

How to test

  1. Start Kibana and Elastic on basic license
  2. Navigate to the license management plugin
  3. Start a trial license
  4. End your trial license
  5. Upload a license (internal company resource)

@jloleysens jloleysens added Feature:License v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Apr 21, 2021
@jloleysens jloleysens requested a review from sebelga April 21, 2021 10:22
@jloleysens jloleysens requested a review from a team as a code owner April 21, 2021 10:22
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @jloleysens ! Tested locally and works as expected 👍

@alisonelizabeth
Copy link
Copy Markdown
Contributor

Just passing through 😄 - I could not find any API integration tests for license management. It might be nice to add some either as part of this PR or open an issue to follow up.

@jloleysens
Copy link
Copy Markdown
Contributor Author

@alisonelizabeth great point! I'll open up an issue for that.

@jloleysens jloleysens merged commit 00c62af into elastic:master Apr 23, 2021
@jloleysens jloleysens deleted the license-management/migrate-legacy-es-client branch April 23, 2021 15:14
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 23, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit that referenced this pull request Apr 23, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:License release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants