Skip to content

Index patterns - scripted field deprecation copy updates #97665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattkime merged 1 commit into from
Apr 20, 2021
Merged

Index patterns - scripted field deprecation copy updates #97665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ..._index_pattern/scripted_fields_table/components/header/__snapshots__/header.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...t/public/components/edit_index_pattern/scripted_fields_table/components/header/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ export const Header = withRouter(({ indexPatternId, history }: HeaderProps) => {
<EuiIcon type="alert" color="warning" style={{ marginRight: '4px' }} />
<FormattedMessage
id="indexPatternManagement.editIndexPattern.deprecation"
defaultMessage="Scripted fields are deprecated, {runtimeDocs}."
defaultMessage="Scripted fields are deprecated. Use {runtimeDocs} instead."
values={{
runtimeDocs: (
<EuiLink target="_blank" href={docLinks.runtimeFields.overview}>
<FormattedMessage
id="indexPatternManagement.header.runtimeLink"
defaultMessage="use runtime fields instead"
defaultMessage="runtime fields"
/>
</EuiLink>
),
Expand Down
20 changes: 10 additions & 10 deletions .../field_editor/components/scripting_call_outs/__snapshots__/warning_call_out.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ...gement/public/components/field_editor/components/scripting_call_outs/warning_call_out.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const ScriptingWarningCallOut = ({ isVisible = false }: ScriptingWarningC
<p>
<FormattedMessage
id="indexPatternManagement.warningCallOutLabel.callOutDetail"
defaultMessage="Please familiarize yourself with {scripFields} and {scriptsInAggregation} before using this feature.
defaultMessage="Familiarize yourself with {scripFields} and {scriptsInAggregation} before using this feature.
Scripted fields can be used to display and aggregate calculated values. As such, they can be very slow and,
if done incorrectly, can cause Kibana to become unusable."
values={{
Expand Down Expand Up @@ -58,7 +58,7 @@ export const ScriptingWarningCallOut = ({ isVisible = false }: ScriptingWarningC
title={
<FormattedMessage
id="indexPatternManagement.scriptedFieldsDeprecatedTitle"
defaultMessage="Scripted fields are deprecated."
defaultMessage="Scripted fields are deprecated"
description="Deprecation warning title within scripted field editor"
/>
}
Expand All @@ -67,13 +67,13 @@ export const ScriptingWarningCallOut = ({ isVisible = false }: ScriptingWarningC
<p>
<FormattedMessage
id="indexPatternManagement.scriptedFieldsDeprecatedBody"
defaultMessage="For greater flexibility and Painless script support, {runtimeDocs}."
defaultMessage="For greater flexibility and Painless script support, use {runtimeDocs}."
values={{
runtimeDocs: (
<EuiLink target="_blank" href={docLinks.runtimeFields.overview}>
<FormattedMessage
id="indexPatternManagement.warningCallOutLabel.runtimeLink"
defaultMessage="use runtime fields"
defaultMessage="runtime fields"
/>
</EuiLink>
),
Expand Down