Skip to content

Index patterns / scripted fields - convert sample data scripted fields to runtime fields #97651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattkime merged 2 commits into from
Apr 20, 2021
+4 −4
Merged

Index patterns / scripted fields - convert sample data scripted fields to runtime fields #97651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
515f276
kibana_sample_data_logs scripted field to runtime field
mattkime Apr 20, 2021
11cb048
use runtime field instead of scripted field for flights sample data
mattkime Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/home/server/services/sample_data/data_sets/flights/saved_objects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,10 +438,10 @@ export const getSavedObjects = (): SavedObject[] => [
attributes: {
title: 'kibana_sample_data_flights',
timeFieldName: 'timestamp',
fields:
'[{"name":"hour_of_day","type":"number","count":0,"scripted":true,"script":"doc[\'timestamp\'].value.hourOfDay","lang":"painless","searchable":true,"aggregatable":true,"readFromDocValues":false}]',
fieldFormatMap:
'{"hour_of_day":{"id":"number","params":{"pattern":"00"}},"AvgTicketPrice":{"id":"number","params":{"pattern":"$0,0.[00]"}}}',
runtimeFieldMap:
'{"hour_of_day":{"type":"long","script":{"source":"emit(doc[\'timestamp\'].value.hourOfDay);"}}}',
},
references: [],
},
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/home/server/services/sample_data/data_sets/logs/saved_objects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,9 +275,9 @@ export const getSavedObjects = (): SavedObject[] => [
attributes: {
title: 'kibana_sample_data_logs',
timeFieldName: 'timestamp',
fields:
'[{"name":"hour_of_day","type":"number","count":0,"scripted":true,"script":"doc[\'timestamp\'].value.getHour()","lang":"painless","searchable":true,"aggregatable":true,"readFromDocValues":false}]',
fieldFormatMap: '{"hour_of_day":{}}',
runtimeFieldMap:
'{"hour_of_day":{"type":"long","script":{"source":"emit(doc[\'timestamp\'].value.getHour());"}}}',
Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, is the discrepancy between the hour_of_day type from number to long because of the saved objects attributes schema?

Copy link
Copy Markdown
Contributor Author

@mattkime mattkime Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TinaHeiligers Good question. No, its because scripted fields use kibana types (javascript) whereas runtime fields use ES field types.

},
references: [],
},
Expand Down