Skip to content

[Canvas] Function usage telemetry#97638

Merged
crob611 merged 4 commits intoelastic:masterfrom
crob611:function-usage-telemetry
Apr 20, 2021
Merged

[Canvas] Function usage telemetry#97638
crob611 merged 4 commits intoelastic:masterfrom
crob611:function-usage-telemetry

Conversation

@crob611
Copy link
Copy Markdown
Contributor

@crob611 crob611 commented Apr 20, 2021

Summary

This adds a couple of buckets for functions in use that keys off a workpad's @timestamp field. This @timestamp field is updated on every workpad save, but we fire off a save when a workpad is loaded (if the user has write permission) so it should hopefully map closely to how recently the workpad was "viewed"

Also took the effort to write descriptions for each of our telemetry fields since that was recently made available.

@crob611 crob611 requested a review from a team as a code owner April 20, 2021 13:34
@crob611 crob611 added Feature:Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.13.0 v8.0.0 labels Apr 20, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@crob611 crob611 added auto-backport Deprecated - use backport:version if exact versions are needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Apr 20, 2021
@crob611
Copy link
Copy Markdown
Contributor Author

crob611 commented Apr 20, 2021

@elasticmachine merge upstream

@crob611 crob611 requested review from a team as code owners April 20, 2021 14:05
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really straightforward. Is there a way to flag or exclude demo workpads?

@crob611
Copy link
Copy Markdown
Contributor Author

crob611 commented Apr 20, 2021

@clintandrewhall Nope, that's something we've talked about in the past that has been a hangup for our telemetry. At least with this strategy, it would only skew data if people are constantly viewing the demo workpads.

We've talked about adding a flag on the workpad schema to mark it as demo, but then we'd have to have some way to mark it as not a demo anymore if someone starts using it for real, but that's kind of hard to detect. So I think this is a good interim solution.

@crob611 crob611 merged commit e7a9b33 into elastic:master Apr 20, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 20, 2021
* Adds telemetry for recent function usage

* Adds description for telemetry fields

* Update Telemetry Schema

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 20, 2021
* Adds telemetry for recent function usage

* Adds description for telemetry fields

* Update Telemetry Schema

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Corey Robertson <corey.robertson@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants