[cliDevMode] set server ready status to false when restarting#97575
Merged
spalger merged 1 commit intoelastic:masterfrom Apr 20, 2021
Merged
[cliDevMode] set server ready status to false when restarting#97575spalger merged 1 commit intoelastic:masterfrom
spalger merged 1 commit intoelastic:masterfrom
Conversation
spalger
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Apr 20, 2021
spalger
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 20, 2021
…c#97575) Co-authored-by: spalger <spalger@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Apr 20, 2021
#97683) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Spencer <email@spalger.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
devServer.ready$tofalsewhen server is first starting up to prevent 502 errors and instead pause requests in the basePathProxy. This used to work but I'm assuming at the extraction of theCliDevModeto a module the ready status stopped getting reset to false when the server was starting up.