Skip to content

[ML] Functional tests - stabilize anomaly charts embeddables test#97452

Merged
pheyos merged 3 commits intoelastic:masterfrom
pheyos:stabilize_embeddables_test
Apr 20, 2021
Merged

[ML] Functional tests - stabilize anomaly charts embeddables test#97452
pheyos merged 3 commits intoelastic:masterfrom
pheyos:stabilize_embeddables_test

Conversation

@pheyos
Copy link
Member

@pheyos pheyos commented Apr 19, 2021 •
edited
Loading

Summary

This PR stabilizes the anomaly charts embeddables test by adding a retry.

Details

Closes #97470

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 19, 2021
@pheyos pheyos requested review from peteharverson and qn895 April 19, 2021 12:51
@pheyos pheyos requested a review from a team as a code owner April 19, 2021 12:51
@pheyos pheyos self-assigned this Apr 19, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 19, 2021

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Apr 19, 2021 •
edited
Loading

Checking test stability in a flaky test runner job ... 1 failure in 50 runs ❌ looking int o it.

@pheyos pheyos mentioned this pull request Apr 20, 2021
Closed
@pheyos
Copy link
Member Author

pheyos commented Apr 20, 2021 •
edited
Loading

After adjusting some timeouts, checking test stability again in a flaky test runner job ... no failure in 50 runs ✔️
Since it only failed once in 50 runs before the last commit: checking again in a second flaky test runner job ... no failure in 50 runs ✔️

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 20, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

peteharverson
peteharverson approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 20, 2021
@pheyos pheyos merged commit a3c2aeb into elastic:master Apr 20, 2021
@pheyos pheyos deleted the stabilize_embeddables_test branch April 20, 2021 09:38
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 20, 2021
@pheyos @kibanamachine
[ML] Functional tests - stabilize anomaly charts embeddables test (el…
c856458 
…astic#97452)

This PR stabilizes the anomaly charts embeddables test by adding a retry.
@kibanamachine kibanamachine mentioned this pull request Apr 20, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 20, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 20, 2021
@kibanamachine @pheyos
[ML] Functional tests - stabilize anomaly charts embeddables test (#9…
1ea3eaa 
…7452) (#97602)

This PR stabilizes the anomaly charts embeddables test by adding a retry.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
@pheyos pheyos mentioned this pull request Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@pheyos pheyos

Labels

auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

4 participants

@pheyos @elasticmachine @kibanamachine @peteharverson