[Discover] Support for runtime fields editor in mobile view#97416
[Discover] Support for runtime fields editor in mobile view#97416majagrubic merged 5 commits intoelastic:masterfrom
Conversation
majagrubic
added
v8.0.0
v7.13.0
release_note:enhancement
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, button is now also displayed in "mobile" view 👍 I've got 1 request, in the current layout the button looks lost, not to say lonely, shouldn't it look like the version for more horizontal screen space?
|
Fair point, was confused with Lens, cause they have it that way 😬 Will change it. |
|
@kertal fixed! indeed it looks better: |
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally in Chrome, Firefox, Safari. Works as expected. Thx for making it pretty! Hurray for completing the runtime fields editor task in Discover 🍾 !
| useNewFieldsApi={true} | ||
| /> | ||
| ); | ||
| expect(component).toMatchSnapshot(); |
There was a problem hiding this comment.
Nit: It would recommendable to create test for more specific cases like clicking on the button, context menu contains 2 menu items, ... however this is good cleanup work and can be done later on
There was a problem hiding this comment.
Will do it in a follow-up PR.
|
btw. think it should be skipped for release notes, since it's part, follow up or completion of a bigger task |
majagrubic
added
release_note:skip
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
…97416) * [Discover] Add runtime fields editor to mobile view * Add a unit test * Fix typescript issues * Fixing layout on mobile Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…97666) * [Discover] Add runtime fields editor to mobile view * Add a unit test * Fix typescript issues * Fixing layout on mobile Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
4 participants
Summary
Follow-up of: #96762
The PR extracts index pattern management code to its own component so that it's available in both DiscoverSidebar and DiscoverSidebarResponsive, thus making it render in mobile view as well.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Documentation was added for features that require explanation or tutorials- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listFor maintainers