Skip to content

[7.x] [Dashboard] Makes lens default editor for creating new panels (#96181)#97414

Merged
cqliu1 merged 4 commits intoelastic:7.xfrom
cqliu1:backport/7.x/pr-96181
Apr 19, 2021
Merged

[7.x] [Dashboard] Makes lens default editor for creating new panels (#96181)#97414
cqliu1 merged 4 commits intoelastic:7.xfrom
cqliu1:backport/7.x/pr-96181

Conversation

@cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Apr 19, 2021

Backports the following commits to 7.x:

…c#96181)

* Makes lens default editor in dashboard

Added all editors menu to dashboard panel toolbar

Fixed toggle on editor menu

Removed unnecessary comments

Added data test subjects to editor menu buttons

Populated editor menu with vis types

Removed unused imports

Fixed imports

Adds showCreateNewMenu prop to AddPanelFlyout

Rearranged order of editor menu options

Fixed ts errors

Added groupnig to embeddable factory

Use embeddable state transfer service to redirect to editors

Added showGroups to TypeSelectionState

Fixed add panel flyout test

Fixed data test subjects

Fixed factory groupings

Removed unused import

Fixed page object

Added telemtry to dashboard toolbar

Added telemtry to editor menu

Fix ml embeddable functional tests

Fix lens dashboard test

Fix empty dashboard test

Fixed ts errors

Fixed time to visualize security test

Fixed empty dashboard test

Fixed clickAddNewEmbeddableLink in dashboardAddPanel service

Fixed agg based vis functional tests

Revert test changes

Fixed typo

Fix tests

Fix more tests

Fix ts errors

Fixed more tests

Fixed toolbar sizes and margins to align with lens

Fix tests

Fixed callbacks

Fixed button prop type

New vis modal copy updates

Added savedObjectMetaData to log stream embeddable factory

Addressed feedback

Fixed ts error

Fix more tests

Fixed ts errors

Updated dashboard empty prompt copy

Adds tooltip to log stream embeddable factory saved object meta data

Made icons monochrome in toolbar

Fixed icon colors in dark mode

Cleaned up css

Fixed ts errors

Updated snapshot

Fixed map icon color

* Added tooltips for ML embeddables

* Restored test

* Added empty dashboard panel test

* Fixed i18n id

* Fix dashboard_embedding test

* Removed unused service

* Fixed i18n error

* Added icon and description properties to embeddable factory definition

* Fixed ts errors

* Fixed expected value

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@cqliu1 cqliu1 added the backport This PR is a backport of another PR label Apr 19, 2021
@cqliu1 cqliu1 enabled auto-merge (squash) April 19, 2021 02:02
@cqliu1
Copy link
Contributor Author

cqliu1 commented Apr 19, 2021

@elasticmachine merge upstream

@cqliu1 cqliu1 force-pushed the backport/7.x/pr-96181 branch from 44bc7dd to 79e7a1e Compare April 19, 2021 17:58
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 189 190 +1
presentationUtil 87 96 +9
total +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 132.6KB 138.9KB +6.3KB
ml 6.0MB 6.0MB +771.0B
visualizations 43.0KB 43.1KB +120.0B
total +7.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 312.8KB 313.0KB +249.0B
embeddable 155.7KB 156.0KB +264.0B
infra 141.4KB 141.6KB +203.0B
ml 67.1KB 67.2KB +113.0B
presentationUtil 33.7KB 37.7KB +4.0KB
visualizations 91.9KB 92.1KB +136.0B
total +5.0KB
Unknown metric groups

API count

id before after diff
embeddable 426 430 +4
presentationUtil 69 70 +1
visualizations 212 237 +25
total +30

API count missing comments

id before after diff
embeddable 361 362 +1
presentationUtil 67 68 +1
visualizations 194 219 +25
total +27

API count with any type

id before after diff
visualizations 11 13 +2

Non-exported public API item count

id before after diff
visualizations 6 5 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit bdb052c into elastic:7.x Apr 19, 2021
@cqliu1 cqliu1 deleted the backport/7.x/pr-96181 branch April 19, 2021 21:04
@cqliu1 cqliu1 restored the backport/7.x/pr-96181 branch June 8, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants