[Fleet] Don't fail on errors in 'update' or 'reupdate' operation in /setup

[skh]

Summary

Completes first implementation of #91864
Follow-up to #95649

This changes /api/fleet/setup such that

• it doesn't error when an error happens during a package upgrade
• its response now contains a property nonFatalPackageUpgradeErrors that reports all errors that have happened during package upgrade

This also changes the Fleet UI so that it shows an error toast when nonFatalPackageUpgradeErrors exists and is not empty.

How to test this:

Craft a system package that triggers an error during installation, serve it from a locally running registry. Do do so, edit any dashboard in system/0.10.9 to include

"migrationVersion": {
    "dashboard": "9.3.0"
  }

instead of 7.3.0.

Start Kibana. Do NOT open the UI yet.

Install a previous, non-broken version of the package with

curl -X POST -u elastic:changeme http://localhost:5601/rch/api/fleet/epm/packages/system-0.10.7 -H 'kbn-xsrf: xyz' -H "Content-Type: application/json" -d '{"force": true}'

Call the setup API endpoint with

curl -X POST -u elastic:changeme http://localhost:5601/rch/api/fleet/setup -H 'kbn-xsrf: xyz'

Observe that the return value contains the error, but also isInitialized: true.

---

Now navigate to the Fleet UI. Observe that you see the full Fleet UI, with an error toast like this:

In dev tools / network, verify that you see the error contained in the response:

---

Now uninstall the nonbroken package (or restart your dev setup to start with an empty database) and call /api/fleet/setup immediately. Verify that it still returns an error (because the error happens during installation, not upgrade).

Open the Fleet UI and verify that you can't use it because the error during installation.

---

Test against the official registry to verify that setup with good packages still works as expected.

Known issues

When you click on "Show the full error" in the error toast, the next modal is empty. I couldn't find a way to pass the error array to the toast notification in the correct form, any help would be appreciated. The full error is visible in dev tools, so I'd suggest this can be fixed in a follow-up change unless I missed something trivial.

When testing that installation of a broken package still blocks the whole UI, #97401 happens.

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[elasticmachine]

Pinging @elastic/fleet (Feature:Fleet)

[skh]

Closing in favor of #97404 because mess-up, sorry for the noise.

[kibanamachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: dd0234e
• Storybooks Preview
• Pipeline Steps (look for red circles / failed steps)
• Interpreting CI Failures

Failed CI Steps

• Jest Unit Tests

---

Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/fleet/server/services/epm/packages.ensureInstalledDefaultPackages should return an array of Installation objects when successful

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toEqual(expected) // deep equality

Expected: [{"es_index_patterns": {"pattern": "pattern-name"}, "id": "test-pkg", "install_source": "registry", "install_started_at": "2021-04-18T16:07:48.260Z", "install_status": "installed", "install_version": "1.0.0", "installed_es": [{"id": "pipeline", "type": "ingest_pipeline"}], "installed_kibana": [{"id": "dashboard-1", "type": "dashboard"}], "name": "test package", "package_assets": [], "version": "1.0.0"}]
Received: {"installations": [{"es_index_patterns": {"pattern": "pattern-name"}, "id": "test-pkg", "install_source": "registry", "install_started_at": "2021-04-18T16:07:48.260Z", "install_status": "installed", "install_version": "1.0.0", "installed_es": [{"id": "pipeline", "type": "ingest_pipeline"}], "installed_kibana": [{"id": "dashboard-1", "type": "dashboard"}], "name": "test package", "package_assets": [], "version": "1.0.0"}], "nonFatalPackageUpgradeErrors": []}
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/fleet/server/services/epm/packages/ensure_installed_default_packages.test.ts:87:18)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

---

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
fleet	787.8KB	788.1KB	+306.0B

Unknown metric groups

API count

id	before	after	diff
fleet	1069	1075	+6

API count missing comments

id	before	after	diff
fleet	979	985	+6

History

• 💔 Build #120385 failed b39f1ac

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @skh