[ML] DataFrame Analytics wizard: improve validation step messaging#97338
Merged
alvarezmelissa87 merged 5 commits intoelastic:masterfrom Apr 20, 2021
Merged
Conversation
alvarezmelissa87
added
:ml
release_note:skip
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
Author
|
cc @lcawl 😄 |
lcawl
reviewed
Apr 16, 2021
Contributor
lcawl
left a comment
lcawl
left a comment
There was a problem hiding this comment.
Two minor suggestions, otherwise text LGTM
Contributor
There was a problem hiding this comment.
Suggested change
| 'Outlier detection requires at least one field to be included in the analysis.', | |
| 'Outlier detection requires that at least one field is included in the analysis.', |
Contributor
Author
There was a problem hiding this comment.
Updated in 97a862cfc489536c59a7b556413f277f8126b5a8
Contributor
There was a problem hiding this comment.
Suggested change
| '{analysisType} requires at least two fields to be included in the analysis.', | |
| '{analysisType} requires that at least two fields are included in the analysis.', |
Contributor
Author
There was a problem hiding this comment.
Updated in 97a862cfc489536c59a7b556413f277f8126b5a8
alvarezmelissa87
force-pushed
the
ml-dfa-validation-updates
branch
from
97a862c to
2efe929
Compare
qn895
approved these changes
Apr 19, 2021
Member
|
Code LGTM |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Apr 20, 2021
…lastic#97338) * improve validation messages and add checks * disable form switch if job created * updated included fields message * update top classes message * update top classes success message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue #88248
Checklist
Delete any items that are not applicable to this PR.