Skip to content

[Uptime] condense waterfall chart visuals#96914

Merged
dominiqueclarke merged 6 commits intoelastic:masterfrom
dominiqueclarke:feature/90913-uptime-waterfall-condense-visuals
Apr 20, 2021
Merged

[Uptime] condense waterfall chart visuals#96914
dominiqueclarke merged 6 commits intoelastic:masterfrom
dominiqueclarke:feature/90913-uptime-waterfall-condense-visuals

Conversation

@dominiqueclarke
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke commented Apr 13, 2021 •
edited
Loading

Fixes #90913

Summary

Condenses the bar height down to 24px and sets the font size to small.

Screen Shot 2021-04-12 at 8 47 46 PM

Screen Shot 2021-04-12 at 8 52 41 PM

Testing

  • Ensure the styling works well with small charts (for example todo)
  • Ensure the styling works well with large charts (for example, www.mlb.com/dodgers
  • Ensure the styling works well with exposed status codes, like 500 errors.

@dominiqueclarke dominiqueclarke requested a review from a team as a code owner April 13, 2021 00:52
@botelastic botelastic Bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 13, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 13, 2021

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke added v7.13.0 release_note:skip Skip the PR/issue when compiling release notes v8.0.0 enhancement New value added to drive a business result labels Apr 13, 2021
@dominiqueclarke
Copy link
Copy Markdown
Contributor Author

dominiqueclarke commented Apr 13, 2021

@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 13, 2021
@shahzad31
Copy link
Copy Markdown
Contributor

shahzad31 commented Apr 15, 2021

To be honest i don't like the condensed view, it looks too crowded , rows looks too close, chart bars are too small, clicking between rows feels like, i am not confident where i am going to click at

thoughts @drewpost @katrin-freihofner

This

image

vs now, our current view is cleaner to look at and read at, click at , interact with.

image

@katrin-freihofner
Copy link
Copy Markdown

katrin-freihofner commented Apr 15, 2021

I agree, I think the text becomes hard to read in the condensed version. cc @liciavale

@dominiqueclarke
Copy link
Copy Markdown
Contributor Author

dominiqueclarke commented Apr 18, 2021

@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke changed the title condense waterfall chart visuals [Uptime] condense waterfall chart visuals Apr 19, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 19, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 950.5KB 950.8KB +328.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31
shahzad31 approved these changes Apr 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !!

Though i still think it's too condensed :D

But since it's a go ahead from design so approving. !!

@dominiqueclarke dominiqueclarke merged commit 1981be0 into elastic:master Apr 20, 2021
@dominiqueclarke dominiqueclarke deleted the feature/90913-uptime-waterfall-condense-visuals branch April 20, 2021 17:25
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 20, 2021
@dominiqueclarke @kibanamachine
[Uptime] condense waterfall chart visuals (elastic#96914)
20a09cd 
* condense waterfall chart visuals

* adjust font size of waterfall chart items to medium

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Apr 20, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 20, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 20, 2021
@kibanamachine @dominiqueclarke
[Uptime] condense waterfall chart visuals (#96914) (#97687)
6e9266b 
* condense waterfall chart visuals

* adjust font size of waterfall chart items to medium

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Uptime] Waterfall: Condense the bars and list rows within the visualization

5 participants

@dominiqueclarke @elasticmachine @shahzad31 @katrin-freihofner @kibanamachine