Skip to content

[Uptime] Monitor Details - add Beta disclaimer to Uptime monitor details title#96886

Merged
dominiqueclarke merged 6 commits intoelastic:masterfrom
dominiqueclarke:feature/91421-synthetics-beta-disclaimer
Apr 20, 2021
Merged

[Uptime] Monitor Details - add Beta disclaimer to Uptime monitor details title#96886
dominiqueclarke merged 6 commits intoelastic:masterfrom
dominiqueclarke:feature/91421-synthetics-beta-disclaimer

Conversation

@dominiqueclarke
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke commented Apr 12, 2021 •
edited by shahzad31
Loading

Fixes #91421

Summary

Adds Beta disclaimer to Uptime monitor details title

Screen Shot 2021-04-12 at 4 00 57 PM

Testing

  • Beta disclaimer DOES NOT appear on tcp monitor
  • Beta disclaimer DOES NOT appear on icmp monitor
  • Beta disclaimer DOES NOT appear on http monitor
  • Beta disclaimer appears on synthetics monitor
  • Beta disclaimer link points to https://www.elastic.co/what-is/synthetic-monitoring
  • Beta disclaimer link opens in a new tab

@dominiqueclarke dominiqueclarke added enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 12, 2021
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner April 12, 2021 20:19
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 12, 2021

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke force-pushed the feature/91421-synthetics-beta-disclaimer branch from 6a7319f to 6c67e2c Compare April 12, 2021 20:20
@dominiqueclarke dominiqueclarke added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 12, 2021
@dominiqueclarke
Copy link
Copy Markdown
Contributor Author

dominiqueclarke commented Apr 12, 2021

@elasticmachine merge upstream

@formgeist
Copy link
Copy Markdown
Contributor

formgeist commented Apr 13, 2021

I personally think the beta label on its own is possibly confusing to whether the monitor created is in beta without more context. Have we thought about adding the monitor type in a EuiBadge and appending the beta label? As an example;

Screenshot 2021-04-13 at 09 17 40

This would add the monitor type to all detail page headers as additional info. The "See more" link would still be available after the badge itself.

cc @katrin-freihofner @paulb-elastic @drewpost

@paulb-elastic
Copy link
Copy Markdown
Contributor

paulb-elastic commented Apr 13, 2021

Just to clarify, the beta disclaimer should only appear for Synthetic (browser) type monitors, not the other ping types.

Essentially, this is replacing the current experimental labelling.

shahzad31
shahzad31 reviewed Apr 13, 2021
View reviewed changes
Comment thread x-pack/plugins/uptime/public/components/monitor/monitor_title.tsx Outdated
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be only for synthetics monitor.

@dominiqueclarke dominiqueclarke force-pushed the feature/91421-synthetics-beta-disclaimer branch from 5dd013d to dc645ff Compare April 13, 2021 18:57
@dominiqueclarke dominiqueclarke force-pushed the feature/91421-synthetics-beta-disclaimer branch from dc645ff to fe7fe41 Compare April 13, 2021 20:48
@dominiqueclarke
Copy link
Copy Markdown
Contributor Author

dominiqueclarke commented Apr 13, 2021

@elasticmachine merge upstream

shahzad31
shahzad31 reviewed Apr 14, 2021
View reviewed changes
Comment thread x-pack/plugins/uptime/public/components/monitor/monitor_title.tsx Outdated
</EuiFlexItem>
</EuiFlexGroup>
{isBrowser && (
<EuiText size="s">
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it makes sense to use Eui beta badge componenet here?https://elastic.github.io/eui/#/display/badge#beta-badge-type

shahzad31
shahzad31 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@dominiqueclarke
Copy link
Copy Markdown
Contributor Author

dominiqueclarke commented Apr 15, 2021

@formgeist I implemented the badge, but we already display the ping type elsewhere. Does this seem repetitive?
image

@dominiqueclarke
Copy link
Copy Markdown
Contributor Author

dominiqueclarke commented Apr 18, 2021

@elasticmachine merge upstream

@paulb-elastic
Copy link
Copy Markdown
Contributor

paulb-elastic commented Apr 19, 2021

I would agreed, the type should be labelled as it is now, with browser/Browser (without ...ping)

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 20, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 950.5KB 952.8KB +2.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 00c7973 into elastic:master Apr 20, 2021
@dominiqueclarke dominiqueclarke deleted the feature/91421-synthetics-beta-disclaimer branch April 20, 2021 17:24
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 20, 2021
@dominiqueclarke @kibanamachine
[Uptime] Monitor Details - add Beta disclaimer to Uptime monitor deta…
5a753d0 
…ils title (elastic#96886)

* add Beta disclaimer to Uptime synthetics monitor details title

* update beta disclaimer to use EUIBadge

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Apr 20, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 20, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 20, 2021
@kibanamachine @dominiqueclarke
[Uptime] Monitor Details - add Beta disclaimer to Uptime monitor deta…
a2714fd 
…ils title (#96886) (#97686)

* add Beta disclaimer to Uptime synthetics monitor details title

* update beta disclaimer to use EUIBadge

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Uptime] Update notices and banners from experimental to beta

6 participants

@dominiqueclarke @elasticmachine @formgeist @paulb-elastic @kibanamachine @shahzad31