Test for Importing saved objects from 6.x to 7.x #96869
Merged
bhavyarm merged 6 commits intoelastic:7.xfrom Apr 13, 2021
Merged
Test for Importing saved objects from 6.x to 7.x #96869bhavyarm merged 6 commits intoelastic:7.xfrom
bhavyarm merged 6 commits intoelastic:7.xfrom
Conversation
bhavyarm
added
test_xpack_functional
Team:QA
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-qa (Team:QA) |
bhavyarm
added
the
release_note:skip
LeeDr
reviewed
Apr 12, 2021
| beforeEach(async function () { | ||
| await esArchiver.load('empty_kibana'); | ||
| await esArchiver.load('logstash_functional'); | ||
| await esArchiver.load('getting_started/shakespeare'); |
There was a problem hiding this comment.
Do we actually need to load 'logstash_functional' and 'getting_started/shakespeare' data? I don't think importing the saved objects care if any data in any time range are used by the saved objects?
Contributor
Author
There was a problem hiding this comment.
We found out that we have to load the data otherwise Kibana will crash.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
LeeDr
approved these changes
Apr 13, 2021
LeeDr
left a comment
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - code review and discussed issues with Bhavya
bhavyarm
added a commit
to bhavyarm/kibana
that referenced
this pull request
Apr 13, 2021
bhavyarm
added a commit
that referenced
this pull request
Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 2 for making sure users can import saved objects between versions. Its importing saved objects from 6.8.x to 7.x.
This PR handled it for 7.x to 8.0.0 #91908