[5.x] Reduce lag experienced when expanding doc table rows#9663
Merged
Conversation
Improves responsiveness by avoiding a couple of forced reflows. * Only renders JSON doc view when requested, instead of rendering it as soon as the row is expanded. * Improves fixedScroll directive by avoiding width/height checks during the digest cycle. (cherry picked from commit b6969f5)
Bargs
force-pushed
the
jasper/backport/9326/5.x
branch
from
ef9f2f3 to
9f10eee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce lag experienced when expanding doc table rows
Backports PR #9326
Commit 1:
Only render JSON view when the user clicks the tab
Commit 2:
Decouple width polling from digest cycle
Commit 3:
documentation
Commit 4:
Flush those timeouts!
Commit 5:
Use debounce instead of timeout
Commit 6:
move assignment into if block
Commit 7:
Mock debounce so the tests don't need to know anything about its internals