[ML] Add ML plugin contract mocks#96265
Merged
qn895 merged 8 commits intoelastic:masterfrom Apr 8, 2021
Merged
Conversation
qn895
added
:ml
release_note:skip
Member
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/ml-ui (:ml) |
rylnd
approved these changes
Apr 6, 2021
Contributor
rylnd
left a comment
rylnd
left a comment
There was a problem hiding this comment.
Changes look great, happy to get this code into the right plugin 😉 . The existing mocks certainly serve our immediate needs, but we'll reach out (likely with a PR) if/when that changes!
|
|
||
| import { MlPluginSetup } from '../../../../ml/server'; | ||
| import { elasticsearchServiceMock } from '../../../../../../src/core/server/mocks'; | ||
| import { mlPluginServerMock } from '../../../../ml/server/mocks'; |
Contributor
There was a problem hiding this comment.
I think kibana preference is to import these mocks directly in the consuming tests, but this makes sense to keep changes here to a minimum 👍 We (SecSol) can absolutely do this in a followup PR.
Member
Author
|
@elasticmachine merge upstream |
qn895
added
the
auto-backport
Member
Author
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @qn895 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 8, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
kibanamachine
added a commit
that referenced
this pull request
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #66603 by adding jest mocks for ML plugins (both public and server API). It also replaces
mlServicesMockfor security solutions from #65583 with the new mock.Checklist