[Enterprise Search] Change order of WS plugin instantiation#96235
Closed
scottybollinger wants to merge 1 commit intoelastic:masterfrom
Closed
[Enterprise Search] Change order of WS plugin instantiation#96235scottybollinger wants to merge 1 commit intoelastic:masterfrom
scottybollinger wants to merge 1 commit intoelastic:masterfrom
Conversation
There was an issue where the console was giving unmounted component errors. Changing the order of the hiding of the Chrome removes the issue.
scottybollinger
added
Feature:Plugins
release_note:skip
yakhinvadim
approved these changes
Apr 5, 2021
Contributor
Author
|
This actually introduced another issue. Now the hidden chrome flashes again so I will need to find another solution |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was an issue where the console was giving unmounted component errors introduced here. Changing the order of the hiding of the Chrome removes the issue. Not sure why hiding the chrome before the data was fetched caused this but I can't seem to get the error to happen again with this order.