-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Fleet] Install security_rule assets as saved objects #95885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rw-access
merged 18 commits into
elastic:master
from
rw-access:fleet-install-security-rule-asset
Apr 8, 2021
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
14e973d
[Fleet] Install security_rule assets as saved objects
rw-access a386384
Add security-rule to update_assets.ts
rw-access f75b1a6
Update UUIDs for security_rule asset
rw-access 82706cc
Change .type to match the saved object type not the asset type
rw-access 53e11a6
Merge branch 'master' into fleet-install-security-rule-asset
kibanamachine 5fe071a
Merge branch 'master' into fleet-install-security-rule-asset
kibanamachine e6b276e
Add saved object mapping for security-rule
rw-access bc2344d
Make SO non-hidden
rw-access e549480
Merge remote-tracking branch 'origin/master' into fleet-install-secur…
rw-access f16ebb5
Merge remote-tracking branch 'origin/master' into fleet-install-secur…
rw-access ef4794d
Fix SO mapping for security-rule
rw-access ce125b5
Make security-rule a non-hidden asset
rw-access c7b49e0
Merge branch 'master' into fleet-install-security-rule-asset
kibanamachine 4f0cfba
Merge branch 'master' into fleet-install-security-rule-asset
kibanamachine bca5044
Merge branch 'master' into fleet-install-security-rule-asset
kibanamachine 6e392fc
Merge branch 'master' into fleet-install-security-rule-asset
kibanamachine 638677e
Merge branch 'master' into fleet-install-security-rule-asset
kibanamachine 3d23655
Merge branch 'master' into fleet-install-security-rule-asset
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...is/fixtures/test_packages/all_assets/0.1.0/kibana/security_rule/sample_security_rule.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| { | ||
| "attributes": { | ||
| "author": [ | ||
| "Elastic" | ||
| ], | ||
| "description": "Identifies a suspicious parent child process relationship with cmd.exe descending from svchost.exe", | ||
| "from": "now-9m", | ||
| "index": [ | ||
| "winlogbeat-*", | ||
| "logs-endpoint.events.*", | ||
| "logs-windows.*" | ||
| ], | ||
| "language": "kuery", | ||
| "license": "Elastic License v2", | ||
| "name": "Svchost spawning Cmd", | ||
| "query": "event.category:process and event.type:(start or process_started) and process.parent.name:svchost.exe and process.name:cmd.exe", | ||
| "risk_score": 21, | ||
| "rule_id": "sample_security_rule", | ||
| "severity": "low", | ||
| "tags": [ | ||
| "Elastic", | ||
| "Host", | ||
| "Windows", | ||
| "Threat Detection", | ||
| "Execution" | ||
| ], | ||
| "threat": [ | ||
| { | ||
| "framework": "MITRE ATT\u0026CK", | ||
| "tactic": { | ||
| "id": "TA0002", | ||
| "name": "Execution", | ||
| "reference": "https://attack.mitre.org/tactics/TA0002/" | ||
| }, | ||
| "technique": [ | ||
| { | ||
| "id": "T1059", | ||
| "name": "Command and Scripting Interpreter", | ||
| "reference": "https://attack.mitre.org/techniques/T1059/" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "timestamp_override": "event.ingested", | ||
| "type": "query", | ||
| "version": 7 | ||
| }, | ||
| "id": "sample_security_rule", | ||
| "type": "security-rule" | ||
| } |
50 changes: 50 additions & 0 deletions
50
...is/fixtures/test_packages/all_assets/0.2.0/kibana/security_rule/sample_security_rule.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| { | ||
| "attributes": { | ||
| "author": [ | ||
| "Elastic" | ||
| ], | ||
| "description": "Identifies a suspicious parent child process relationship with cmd.exe descending from svchost.exe", | ||
| "from": "now-9m", | ||
| "index": [ | ||
| "winlogbeat-*", | ||
| "logs-endpoint.events.*", | ||
| "logs-windows.*" | ||
| ], | ||
| "language": "kuery", | ||
| "license": "Elastic License v2", | ||
| "name": "Svchost spawning Cmd", | ||
| "query": "event.category:process and event.type:(start or process_started) and process.parent.name:svchost.exe and process.name:cmd.exe", | ||
| "risk_score": 21, | ||
| "rule_id": "sample_security_rule", | ||
| "severity": "low", | ||
| "tags": [ | ||
| "Elastic", | ||
| "Host", | ||
| "Windows", | ||
| "Threat Detection", | ||
| "Execution" | ||
| ], | ||
| "threat": [ | ||
| { | ||
| "framework": "MITRE ATT\u0026CK", | ||
| "tactic": { | ||
| "id": "TA0002", | ||
| "name": "Execution", | ||
| "reference": "https://attack.mitre.org/tactics/TA0002/" | ||
| }, | ||
| "technique": [ | ||
| { | ||
| "id": "T1059", | ||
| "name": "Command and Scripting Interpreter", | ||
| "reference": "https://attack.mitre.org/techniques/T1059/" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "timestamp_override": "event.ingested", | ||
| "type": "query", | ||
| "version": 7 | ||
| }, | ||
| "id": "sample_security_rule", | ||
| "type": "security-rule" | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FrankHassanabad is this change okay?
for some reason, it doesn't look like fleet hasn't yet recognized this saved object when running tests (at least locally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok. Don't see anything weird here.