[cli-dev-mode/optimizer] omit pageLoadAssetSizeLimit from cache#95826
Merged
spalger merged 4 commits intoelastic:masterfrom Mar 30, 2021
Merged
[cli-dev-mode/optimizer] omit pageLoadAssetSizeLimit from cache#95826spalger merged 4 commits intoelastic:masterfrom
spalger merged 4 commits intoelastic:masterfrom
Conversation
…upport --verbose logging
spalger
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Mar 30, 2021
mshustov
approved these changes
Mar 30, 2021
spalger
added
the
auto-backport
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 30, 2021
…tic#95826) Co-authored-by: spalger <spalger@users.noreply.github.com>
Contributor
kibanamachine
added a commit
that referenced
this pull request
Mar 31, 2021
…) (#95856) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Spencer <email@spalger.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #95822 I noticed a bug in the
@kbn/optimizercache that I believe @weltenwort had noticed before but we hadn't tracked down, wherenode scripts/build_kibana_platform_pluginswould report that all bundles were cached but they would then be rebuilt when you runyarn start. The problem comes from #93153, where the limitsPath became a parameter passed in via the config. This param isn't passed to the optimizer when it's run viayarn start, and since limits have no bering on the output of the bundles that is fine. To fix this I've excluded thepageLoadAssetSizeLimitfrom the cache key created for each Bundle which will allow two executions of the@kbn/optimizerwhich only differ in--limitsconfig to share caches.To aid in debugging and testing this I also added support for passing the
--verboseflag passed toyarn startthrough to the@kbn/optimizerto enable its verbose logging.