[ML] Type updates after esclient type update#95658
Merged
jgowdyelastic merged 7 commits intoelastic:masterfrom Apr 20, 2021
Merged
[ML] Type updates after esclient type update#95658jgowdyelastic merged 7 commits intoelastic:masterfrom
jgowdyelastic merged 7 commits intoelastic:masterfrom
Conversation
Member
Author
|
@elasticmachine merge upstream |
jgowdyelastic
added
:ml
non-issue
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Member
Author
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Unknown metric groupsAPI count
API count missing comments
API count with any type
Non-exported public API item count
History
To update your PR or re-run it, just comment with: |
jgowdyelastic
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 20, 2021
* [ML] Type updates after esclient type update * reverting expect errors * fixing type errors * tiny refactor Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Apr 20, 2021
* [ML] Type updates after esclient type update * reverting expect errors * fixing type errors * tiny refactor Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: James Gowdy <jgowdy@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on type updates, correcting some type changes made in #83808 and updating some
// @ts-expect-errordescriptions.Requires additional esclient type changes requested here
elastic/elasticsearch-specification#252
Update:
// @ts-expect-errorchanges have been reverted as the current esclient version has not been bumped and so does not contain the fixed types. So in an effort to get this merged for 7.13, it was decided to revert these changes.