Skip to content

Set Button component to display: inline-block. #9541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjcenizal merged 1 commit into from
Dec 16, 2016
Merged

Set Button component to display: inline-block. #9541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/ui_framework/components/button/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
/**
* 1. Disable for Angular.
* 1. Setting to inline-block guarantees the same height when applied to both
* button elements and anchor tags.
* 2. Disable for Angular.
*/
.kuiButton {
display: inline-block; /* 1 */
appearance: none;
padding: 4px 12px 5px;
font-size: $fontSize;
Expand All @@ -14,7 +17,7 @@

&:disabled {
cursor: default;
pointer-events: none; // 1
pointer-events: none; /* 2 */
}

&:active:enabled {
Expand Down
4 changes: 0 additions & 4 deletions src/ui_framework/doc_site/src/views/button/button_elements.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,12 @@
Button element
</button>

<hr class="guideBreak">

<input
type="submit"
class="kuiButton kuiButton--basic"
value="Submit input element"
>

<hr class="guideBreak">

<a href="#" class="kuiButton kuiButton--basic">
Anchor element
</a>