Correctly reference the default bucket for the release task #9493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration is nested under options instead of config in the new aws_s3 library. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added
Team:Core
tylersmalley
commented
Dec 14, 2016
| accessKeyId: config.key, | ||
| secretAccessKey: config.secret, | ||
| bucket: config.bucket || grunt.config.get('aws_s3.config.bucket'), | ||
| bucket: config.bucket || grunt.config.get('aws_s3.options.bucket'), |
Member
Author
There was a problem hiding this comment.
The configuration file for reference: https://github.com/elastic/kibana/blob/master/tasks/config/aws_s3.js#L6
Contributor
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Dec 15, 2016
Backports PR #9493 **Commit 1:** Correctly reference the default bucket for the release task The configuration is nested under options instead of config in the new aws_s3 library. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Original sha: 789b2bf * Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-12-14T23:26:43Z
tylersmalley
pushed a commit
that referenced
this pull request
Dec 15, 2016
Backports PR #9493 **Commit 1:** Correctly reference the default bucket for the release task The configuration is nested under options instead of config in the new aws_s3 library. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Original sha: 789b2bf * Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-12-14T23:26:43Z
Contributor
|
@tylersmalley Is this broken on 5.1 and 5.0? If so, can you backport this there as well? What about 4.7? |
epixa
added
Team:Operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration is nested under options instead of config in the new aws_s3 library.