Merged
Conversation
Contributor
|
Looks like |
cjcenizal
approved these changes
Dec 13, 2016
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
LGTM, just need to fix the licenses check
Contributor
|
Pulled the changes and built it successfully . Kibana starts up successfully . LGTM. |
Contributor
Author
|
As far as I can tell, the "Unlicense" license is basically public-domain, so I've added it to the allowed list. I also sent a request to legal for some CYA, we can revert this if necessary. |
elastic-jasper
added a commit
that referenced
this pull request
Dec 13, 2016
Backports PR #9463 **Commit 1:** [uiFramework] include sass deps in production so we can rebuild * Original sha: aae8eec * Authored by spalger <spalger@users.noreply.github.com> on 2016-12-13T19:08:06Z **Commit 2:** [build] do not copy the doc_site source into the final build * Original sha: fccbe49 * Authored by spalger <spalger@users.noreply.github.com> on 2016-12-13T19:08:31Z **Commit 3:** [licenses] allow code that uses the `Unlicense` * Original sha: 9406b9e * Authored by spalger <spalger@users.noreply.github.com> on 2016-12-13T20:46:19Z
spalger
pushed a commit
that referenced
this pull request
Dec 13, 2016
Backports PR #9463 **Commit 1:** [uiFramework] include sass deps in production so we can rebuild * Original sha: aae8eec * Authored by spalger <spalger@users.noreply.github.com> on 2016-12-13T19:08:06Z **Commit 2:** [build] do not copy the doc_site source into the final build * Original sha: fccbe49 * Authored by spalger <spalger@users.noreply.github.com> on 2016-12-13T19:08:31Z **Commit 3:** [licenses] allow code that uses the `Unlicense` * Original sha: 9406b9e * Authored by spalger <spalger@users.noreply.github.com> on 2016-12-13T20:46:19Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We forgot to test building when adding the ui framework 🤓
This fixes the build so that sass is included in production (required to rebuild with plugins) and does not include the doc_site source in the final distributable.