[Logs UI] Style improvements for log stream search strategy by weltenwort · Pull Request #94560 · elastic/kibana

weltenwort · 2021-03-15T12:07:27Z

Summary

This implements the code style improvements I suggested for #94443, which we merged without discussing them for BC timing reasons.

kibanamachine · 2021-03-15T14:06:34Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 7431839
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup8

Test Failures

Kibana Pipeline / general / X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/delete·ts.spaces api with security delete superuser from the space_1 space should return 204 when referencing the space_1 space explicitly in the URL

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/92358

[00:00:00]       │
[00:00:00]         └-: spaces api with security
[00:00:00]           └-> "before all" hook in "spaces api with security"
[00:00:00]           └-> "before all" hook in "spaces api with security"
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_legacy_user]
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] [.ds-ilm-history-5-2021.03.15-000001] creating index, cause [initialize_data_stream], templates [ilm-history], shards [1]/[0]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_dual_privileges_user]
[00:00:00]             │ info [o.e.c.m.MetadataCreateDataStreamService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] adding data stream [ilm-history-5] with write index [.ds-ilm-history-5-2021.03.15-000001] and backing indices []
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] moving index [.ds-ilm-history-5-2021.03.15-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] moving index [.ds-ilm-history-5-2021.03.15-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] moving index [.ds-ilm-history-5-2021.03.15-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_dashboard_only_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_default_space_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_default_space_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_space_1_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_space_1_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_space_2_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_space_2_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_space_1_2_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_space_1_2_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_default_space_saved_objects_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_default_space_saved_objects_read_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_space_1_saved_objects_all_user]
[00:00:00]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added role [kibana_rbac_space_1_saved_objects_read_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [not_a_kibana_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_default_space_all_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_default_space_read_user]
[00:00:01]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_space_1_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_space_2_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_space_2_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_space_1_2_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_space_1_2_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_default_space_saved_objects_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_default_space_saved_objects_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_space_1_saved_objects_all_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_kibana_rbac_space_1_saved_objects_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_apm_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_machine_learning_admin]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_machine_learning_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] added user [a_monitoring_user]
[00:03:53]           └-: delete
[00:03:53]             └-> "before all" hook in "delete"
[00:04:55]             └-: superuser from the space_1 space
[00:04:55]               └-> "before all" hook for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:55]               └-> should return 204 when referencing the space_1 space explicitly in the URL
[00:04:55]                 └-> "before each" hook: global before each for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:55]                 └-> "before each" hook for "should return 204 when referencing the space_1 space explicitly in the URL"
[00:04:55]                   │ info [saved_objects/spaces] Loading "mappings.json"
[00:04:55]                   │ info [saved_objects/spaces] Loading "data.json"
[00:04:55]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] [.kibana_8.0.0_001/3gJcsLB2QcSulsPqmtMOYQ] deleting index
[00:04:55]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] [.kibana_task_manager_8.0.0_001/K6yvu5DuToCgdi2xXmooFA] deleting index
[00:04:55]                   │ info [saved_objects/spaces] Deleted existing index ".kibana_8.0.0_001"
[00:04:55]                   │ info [saved_objects/spaces] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:04:55]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] [.kibana_8.0.0_001] creating index, cause [api], templates [], shards [1]/[0]
[00:04:55]                   │ info [saved_objects/spaces] Created index ".kibana_8.0.0_001"
[00:04:55]                   │ debg [saved_objects/spaces] ".kibana_8.0.0_001" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:55]                   │ info [saved_objects/spaces] Indexed 31 docs into ".kibana"
[00:04:55]                   │ debg Migrating saved objects
[00:04:56]                   │ proc [kibana]   log   [13:05:11.719] [warning][collector-set][plugins][usageCollection] ResponseError: index_not_found_exception
[00:04:56]                   │ proc [kibana]     at onBody (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.onEnd (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.emit (events.js:327:22)
[00:04:56]                   │ proc [kibana]     at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:56]                   │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:80:21) {
[00:04:56]                   │ proc [kibana]   meta: {
[00:04:56]                   │ proc [kibana]     body: { error: [Object], status: 404 },
[00:04:56]                   │ proc [kibana]     statusCode: 404,
[00:04:56]                   │ proc [kibana]     headers: {
[00:04:56]                   │ proc [kibana]       'content-type': 'application/json;charset=utf-8',
[00:04:56]                   │ proc [kibana]       'content-length': '449'
[00:04:56]                   │ proc [kibana]     },
[00:04:56]                   │ proc [kibana]     meta: {
[00:04:56]                   │ proc [kibana]       context: null,
[00:04:56]                   │ proc [kibana]       request: [Object],
[00:04:56]                   │ proc [kibana]       name: 'elasticsearch-js',
[00:04:56]                   │ proc [kibana]       connection: [Object],
[00:04:56]                   │ proc [kibana]       attempts: 0,
[00:04:56]                   │ proc [kibana]       aborted: false
[00:04:56]                   │ proc [kibana]     }
[00:04:56]                   │ proc [kibana]   }
[00:04:56]                   │ proc [kibana] }
[00:04:56]                   │ proc [kibana]   log   [13:05:11.725] [warning][collector-set][plugins][usageCollection] Unable to fetch data from core collector
[00:04:56]                   │ proc [kibana]   log   [13:05:11.758] [warning][collector-set][plugins][usageCollection] ResponseError: search_phase_execution_exception
[00:04:56]                   │ proc [kibana]     at onBody (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.onEnd (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
[00:04:56]                   │ proc [kibana]     at IncomingMessage.emit (events.js:327:22)
[00:04:56]                   │ proc [kibana]     at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:56]                   │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:80:21) {
[00:04:56]                   │ proc [kibana]   meta: {
[00:04:56]                   │ proc [kibana]     body: { error: [Object], status: 400 },
[00:04:56]                   │ proc [kibana]     statusCode: 400,
[00:04:56]                   │ proc [kibana]     headers: {
[00:04:56]                   │ proc [kibana]       'content-type': 'application/json;charset=utf-8',
[00:04:56]                   │ proc [kibana]       'content-length': '752'
[00:04:56]                   │ proc [kibana]     },
[00:04:56]                   │ proc [kibana]     meta: {
[00:04:56]                   │ proc [kibana]       context: null,
[00:04:56]                   │ proc [kibana]       request: [Object],
[00:04:56]                   │ proc [kibana]       name: 'elasticsearch-js',
[00:04:56]                   │ proc [kibana]       connection: [Object],
[00:04:56]                   │ proc [kibana]       attempts: 0,
[00:04:56]                   │ proc [kibana]       aborted: false
[00:04:56]                   │ proc [kibana]     }
[00:04:56]                   │ proc [kibana]   }
[00:04:56]                   │ proc [kibana] }
[00:04:56]                   │ proc [kibana]   log   [13:05:11.759] [warning][collector-set][plugins][usageCollection] Unable to fetch data from saved_objects_tagging collector
[00:04:56]                   │ proc [kibana]   log   [13:05:11.779] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET
[00:04:56]                   │ proc [kibana]   log   [13:05:11.783] [info][savedobjects-service] [.kibana] INIT -> OUTDATED_DOCUMENTS_SEARCH
[00:04:56]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:04:56]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:04:56]                   │ proc [kibana]   log   [13:05:11.790] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> UPDATE_TARGET_MAPPINGS
[00:04:56]                   │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] [.kibana_8.0.0_001/AuT1Ul3AQlKw__RSimd48g] update_mapping [_doc]
[00:04:56]                   │ proc [kibana]   log   [13:05:11.854] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK
[00:04:56]                   │ proc [kibana]   log   [13:05:11.862] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY
[00:04:56]                   │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] 60439 finished with response BulkByScrollResponse[took=21.8ms,timed_out=false,sliceId=null,updated=31,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:04:56]                   │ proc [kibana]   log   [13:05:11.887] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE
[00:04:56]                   │ proc [kibana]   log   [13:05:11.887] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 116ms
[00:04:56]                   │ proc [kibana]   log   [13:05:11.961] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> DONE
[00:04:56]                   │ proc [kibana]   log   [13:05:11.961] [info][savedobjects-service] [.kibana] Migration completed after 191ms
[00:04:56]                   │ debg [saved_objects/spaces] Migrated Kibana index after loading Kibana data
[00:04:56]                   │ debg [saved_objects/spaces] Ensured that default space exists in .kibana
[00:04:56]                   │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1615810080691219375] [.kibana_8.0.0_001/AuT1Ul3AQlKw__RSimd48g] update_mapping [_doc]
[00:04:57]                 └- ✖ fail: spaces api with security delete superuser from the space_1 space should return 204 when referencing the space_1 space explicitly in the URL
[00:04:57]                 │       Error: expected [ { key: 'default',
[00:04:57]                 │     doc_count: 8,
[00:04:57]                 │     countByType: 
[00:04:57]                 │      { doc_count_error_upper_bound: 0,
[00:04:57]                 │        sum_other_doc_count: 0,
[00:04:57]                 │        buckets: [Object] } },
[00:04:57]                 │   { key: 'space_1',
[00:04:57]                 │     doc_count: 7,
[00:04:57]                 │     countByType: 
[00:04:57]                 │      { doc_count_error_upper_bound: 0,
[00:04:57]                 │        sum_other_doc_count: 0,
[00:04:57]                 │        buckets: [Object] } } ] to sort of equal [ { key: 'default',
[00:04:57]                 │     doc_count: 9,
[00:04:57]                 │     countByType: 
[00:04:57]                 │      { doc_count_error_upper_bound: 0,
[00:04:57]                 │        sum_other_doc_count: 0,
[00:04:57]                 │        buckets: [Object] } },
[00:04:57]                 │   { doc_count: 7,
[00:04:57]                 │     key: 'space_1',
[00:04:57]                 │     countByType: 
[00:04:57]                 │      { doc_count_error_upper_bound: 0,
[00:04:57]                 │        sum_other_doc_count: 0,
[00:04:57]                 │        buckets: [Object] } } ]
[00:04:57]                 │       + expected - actual
[00:04:57]                 │ 
[00:04:57]                 │                  "key": "space"
[00:04:57]                 │                }
[00:04:57]                 │                {
[00:04:57]                 │                  "doc_count": 1
[00:04:57]                 │       +          "key": "config"
[00:04:57]                 │       +        }
[00:04:57]                 │       +        {
[00:04:57]                 │       +          "doc_count": 1
[00:04:57]                 │                  "key": "index-pattern"
[00:04:57]                 │                }
[00:04:57]                 │              ]
[00:04:57]                 │              "doc_count_error_upper_bound": 0
[00:04:57]                 │              "sum_other_doc_count": 0
[00:04:57]                 │            }
[00:04:57]                 │       -    "doc_count": 8
[00:04:57]                 │       +    "doc_count": 9
[00:04:57]                 │            "key": "default"
[00:04:57]                 │          }
[00:04:57]                 │          {
[00:04:57]                 │            "countByType": {
[00:04:57]                 │       
[00:04:57]                 │       at Assertion.assert (/dev/shm/workspace/parallel/1/kibana/packages/kbn-expect/expect.js:100:11)
[00:04:57]                 │       at Assertion.eql (/dev/shm/workspace/parallel/1/kibana/packages/kbn-expect/expect.js:244:8)
[00:04:57]                 │       at expectEmptyResult (test/spaces_api_integration/common/suites/delete.ts:133:24)
[00:04:57]                 │       at runMicrotasks (<anonymous>)
[00:04:57]                 │       at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:04:57]                 │ 
[00:04:57]                 │

Stack Trace

Error: expected [ { key: 'default',
    doc_count: 8,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } },
  { key: 'space_1',
    doc_count: 7,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } } ] to sort of equal [ { key: 'default',
    doc_count: 9,
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } },
  { doc_count: 7,
    key: 'space_1',
    countByType: 
     { doc_count_error_upper_bound: 0,
       sum_other_doc_count: 0,
       buckets: [Object] } } ]
    at Assertion.assert (/dev/shm/workspace/parallel/1/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/1/kibana/packages/kbn-expect/expect.js:244:8)
    at expectEmptyResult (test/spaces_api_integration/common/suites/delete.ts:133:24)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5) {
  actual: '[\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "space"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 8\n' +
    '    "key": "default"\n' +
    '  }\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 7\n' +
    '    "key": "space_1"\n' +
    '  }\n' +
    ']',
  expected: '[\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "space"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 9\n' +
    '    "key": "default"\n' +
    '  }\n' +
    '  {\n' +
    '    "countByType": {\n' +
    '      "buckets": [\n' +
    '        {\n' +
    '          "doc_count": 3\n' +
    '          "key": "visualization"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 2\n' +
    '          "key": "dashboard"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "config"\n' +
    '        }\n' +
    '        {\n' +
    '          "doc_count": 1\n' +
    '          "key": "index-pattern"\n' +
    '        }\n' +
    '      ]\n' +
    '      "doc_count_error_upper_bound": 0\n' +
    '      "sum_other_doc_count": 0\n' +
    '    }\n' +
    '    "doc_count": 7\n' +
    '    "key": "space_1"\n' +
    '  }\n' +
    ']',
  showDiff: true
}

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

elasticmachine · 2021-03-15T14:44:54Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Kerry350

LGTM 👍

…94560)

kibanamachine · 2021-03-16T12:32:40Z

💚 Backport successful

✅ 7.12 / #94685
✅ 7.x / #94686

Successful backport PRs will be merged automatically after passing CI.

…94685) Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>

…94686) Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>

Align signatures and call sites for helper functions

7431839

weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Mar 15, 2021

weltenwort added this to the Logs UI 7.12 milestone Mar 15, 2021

weltenwort self-assigned this Mar 15, 2021

weltenwort added v7.13.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 15, 2021

weltenwort marked this pull request as ready for review March 15, 2021 14:44

weltenwort requested a review from a team as a code owner March 15, 2021 14:44

weltenwort requested a review from Kerry350 March 15, 2021 14:45

Kerry350 approved these changes Mar 16, 2021

View reviewed changes

weltenwort merged commit e830e07 into elastic:master Mar 16, 2021

weltenwort deleted the logs-ui-pr-94443-style-follow-up branch March 16, 2021 12:29

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 16, 2021

[Logs UI] Style improvements for log stream search strategy (elastic#…

9b56528

…94560)

This was referenced Mar 16, 2021

[7.12] [Logs UI] Style improvements for log stream search strategy (#94560) #94685

Merged

[7.x] [Logs UI] Style improvements for log stream search strategy (#94560) #94686

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 16, 2021

[Logs UI] Style improvements for log stream search strategy (elastic#…

62fb015

…94560)

kibanamachine added a commit that referenced this pull request Mar 16, 2021

[Logs UI] Style improvements for log stream search strategy (#94560) (#…

4355b1f

…94685) Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>

kibanamachine added a commit that referenced this pull request Mar 16, 2021

[Logs UI] Style improvements for log stream search strategy (#94560) (#…

68687e0

…94686) Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>

sorenlouv mentioned this pull request Mar 17, 2021

[Github Action] Add backport workflow elastic/beats#24576

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logs UI] Style improvements for log stream search strategy#94560

[Logs UI] Style improvements for log stream search strategy#94560
weltenwort merged 1 commit intoelastic:masterfrom
weltenwort:logs-ui-pr-94443-style-follow-up

weltenwort commented Mar 15, 2021

Uh oh!

kibanamachine commented Mar 15, 2021

Standard Out

Stack Trace

Uh oh!

elasticmachine commented Mar 15, 2021

Uh oh!

Kerry350 left a comment •

edited

Loading

Uh oh!

kibanamachine commented Mar 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

weltenwort commented Mar 15, 2021

Summary

Uh oh!

kibanamachine commented Mar 15, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Uh oh!

elasticmachine commented Mar 15, 2021

Uh oh!

Kerry350 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 16, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kerry350 left a comment •

edited

Loading