Expose filter item from data plugin

[shahzad31]

Summary

we are using this component in our exploratory view #94426

so exposing it from data plugin.

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[shahzad31]

@elasticmachine merge upstream

[Dosant]

LGTM, didn't test, one suggest 👇

[Dosant]

Can we type this EuiContextMenuPanelItemDescriptor & {id: PanelOptions} and then use id for filtering hiddenPanelOptions 🙏

Would be nice to have hiddenPanelOptions type connected to actually panel items and not use an arbitrary data-test-subj string for this

[shahzad31]

i tried adding id or using EuiContextMenuPanelItemDescriptor, typescript goes crazy in both cases.

[shahzad31]

working with EUI items types can be tricky , so i am not sure, how to solve this.

[Dosant]

Wow, indeed tricky!

To workaround eui types, I ended up with:

type PanelOptions = 'pinFilter' | 'editFilter' | 'negateFilter' | 'disableFilter' | 'deleteFilter';

interface PanelItem {
  id: PanelOptions;
  euiPanel: EuiContextMenuPanelItemDescriptor;
}

....

let mainPanelItems: PanelItem[] = [
      {
        id: 'pinFilter',
        euiPanel: {
          name: isFilterPinned(filter)
            ? props.intl.formatMessage({
                id: 'data.filter.filterBar.unpinFilterButtonLabel',
                defaultMessage: 'Unpin',
              })
            : props.intl.formatMessage({
                id: 'data.filter.filterBar.pinFilterButtonLabel',
                defaultMessage: 'Pin across all apps',
              }),
          icon: 'pin',
          onClick: () => {
            setIsPopoverOpen(false);
            onTogglePinned();
          },
          'data-test-subj': 'pinFilter',
        },
      },
....
    ];

And then filter panels by id: 'pinFilter',

to be honest, I still think it is worth it

[shahzad31]

^^ i don't think that will work.

[shahzad31]

so i am leaving this improvement perhaps for future :)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 1352b25
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
data	211.3KB	214.2KB	+2.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	807.6KB	807.4KB	-177.0B

Unknown metric groups

async chunk count

id	before	after	diff
data	9	11	+2

History

• 💚 Build #113031 succeeded 5c92368
• 💔 Build #113020 failed 4de8ada

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

[Dosant]

Change LGTM,

I still think it is worth improving type binding within the component:
https://github.com/elastic/kibana/pull/94546/files#r596662205

[kibanamachine]

💚 Backport successful

✅ 7.x / #94964

This backport PR will be merged automatically after passing CI.