Skip to content

[Asset Management] Osquery agent picker#94541

Merged
lykkin merged 20 commits intoelastic:masterfrom
lykkin:osquery-livequery-host-picker
Mar 31, 2021
Merged

[Asset Management] Osquery agent picker#94541
lykkin merged 20 commits intoelastic:masterfrom
lykkin:osquery-livequery-host-picker

Conversation

@lykkin
Copy link
Copy Markdown
Contributor

@lykkin lykkin commented Mar 15, 2021

Summary

Lands a rough draft of the agent picker for live query. Proper host pagination/styling to follow.
osquery-host-picker

@lykkin lykkin added v8.0.0 v7.13.0 Team:Asset Management Security Asset Management Team Feature:Osquery Security Solution Osquery feature auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 15, 2021
@lykkin lykkin requested a review from a team as a code owner March 15, 2021 06:04
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

@lykkin
Copy link
Copy Markdown
Contributor Author

lykkin commented Mar 23, 2021

@elasticmachine merge upstream

@lykkin lykkin self-assigned this Mar 23, 2021
Comment thread x-pack/plugins/osquery/public/agents/use_osquery_policies.ts Outdated
Comment thread x-pack/plugins/osquery/server/routes/action/create_action_route.ts Outdated
Comment thread x-pack/plugins/osquery/server/routes/action/create_action_route.ts Outdated
Comment thread x-pack/plugins/osquery/public/agents/use_osquery_policies.ts Outdated
Comment thread x-pack/plugins/osquery/public/agents/use_agent_groups.ts Outdated
Comment thread x-pack/plugins/osquery/public/agents/use_agent_groups.ts Outdated
Comment thread x-pack/plugins/osquery/public/agents/helpers.ts Outdated
Comment thread x-pack/plugins/osquery/public/agents/agents_table.tsx Outdated
Comment thread x-pack/plugins/osquery/public/agents/agents_table.tsx Outdated
Comment thread x-pack/plugins/osquery/public/agents/agents_table.tsx Outdated
Comment thread x-pack/plugins/osquery/common/search_strategy/osquery/index.ts Outdated
@lykkin
Copy link
Copy Markdown
Contributor Author

lykkin commented Mar 25, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

merge conflict between base and head

@lykkin
Copy link
Copy Markdown
Contributor Author

lykkin commented Mar 29, 2021

@elasticmachine merge upstream

@lykkin
Copy link
Copy Markdown
Contributor Author

lykkin commented Mar 29, 2021

@patrykkopycinski should be ready for another look when you can spare the 👀 !

@lykkin lykkin requested a review from patrykkopycinski March 30, 2021 03:29
Comment thread x-pack/plugins/osquery/common/search_strategy/osquery/index.ts Outdated
Comment thread x-pack/plugins/osquery/public/action_results/action_results_table.tsx Outdated
Comment thread x-pack/plugins/osquery/public/agents/agents_table.tsx Outdated
Comment thread x-pack/plugins/osquery/public/agents/agents_table.tsx Outdated
Comment thread x-pack/plugins/osquery/public/agents/helpers.test.ts
Copy link
Copy Markdown
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@lykkin
Copy link
Copy Markdown
Contributor Author

lykkin commented Mar 31, 2021

@elasticmachine merge upstream

@lykkin lykkin enabled auto-merge (squash) March 31, 2021 08:10
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
osquery 137 141 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 764.0KB 769.7KB +5.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
osquery 10.9KB 11.1KB +299.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lykkin

@lykkin lykkin merged commit e365396 into elastic:master Mar 31, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 31, 2021
* first pass of osquery host picker

* passes type checking and linting

* reworked everything

* fixed the policy query and pill colors

* fix i18n test failures

* refactor server side logic

* more clean up

* address pr comments

* fix types, await the parsed agents on the server side

* primitive is spelled with an i

* agents come in as list rather than agents

* added more helpers tests, added some edge case guarding

* unwrap agents off response in useAllAgents

* used proper types for aggregations

* translations for more ui text

* fix linting errors

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

7.x / #95891

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 31, 2021
* first pass of osquery host picker

* passes type checking and linting

* reworked everything

* fixed the policy query and pill colors

* fix i18n test failures

* refactor server side logic

* more clean up

* address pr comments

* fix types, await the parsed agents on the server side

* primitive is spelled with an i

* agents come in as list rather than agents

* added more helpers tests, added some edge case guarding

* unwrap agents off response in useAllAgents

* used proper types for aggregations

* translations for more ui text

* fix linting errors

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Bryan Clement <bclement01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Osquery Security Solution Osquery feature release_note:enhancement Team:Asset Management Security Asset Management Team v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants