Skip to content

App Services API updates for CSV Export #94537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 16, 2021
Merged

App Services API updates for CSV Export #94537

merged 3 commits into from
Mar 16, 2021

Conversation

@tsullivan
Copy link
Member

@tsullivan tsullivan commented Mar 14, 2021 •
edited
Loading

Summary

Changes to App Services APIs that make way for CSV Export using SearchSource: #88303

  • export the IScopedSearchClient type for server-side
  • create a function to load getSharingData as an async module
  • add logging in es_search_strategy to show the cause of error in the server logs

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@tsullivan tsullivan requested a review from a team March 14, 2021 20:22
@tsullivan tsullivan requested a review from a team as a code owner March 14, 2021 20:22
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes Team:AppServices v7.13.0 v8.0.0 labels Mar 14, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 14, 2021

Pinging @elastic/kibana-app-services (Team:AppServices)

@tsullivan tsullivan changed the title App Arch API updates for CSV Export App Services API updates for CSV Export Mar 14, 2021
ppisljar
ppisljar reviewed Mar 15, 2021
View reviewed changes
ppisljar
ppisljar approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 15, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 339 340 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 402.0KB 409.2KB +7.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 79.6KB 79.8KB +270.0B
Unknown metric groups

async chunk count

id before after diff
discover 6 7 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal
kertal reviewed Mar 16, 2021
View reviewed changes
src/plugins/discover/public/index.ts

export { SavedSearch, SavedSearchLoader, createSavedSearchesLoader } from './saved_searches';
export { ISearchEmbeddable, SEARCH_EMBEDDABLE_TYPE, SearchInput } from './application/embeddable';
export { loadSharingDataHelpers } from './shared';
Copy link
Member

@kertal kertal Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be used server side, right? so I think loadSharingDataHelpers should live in src/plugins/discover/common

Copy link
Member Author

@tsullivan tsullivan Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to be used in public code (dashboard panel action: https://github.com/elastic/kibana/pull/88303/files#diff-0154cfbb823111800ea5acf098c44670bcf6035935df851983db9f2c55bfe16cR66

@tsullivan tsullivan merged commit 067543b into elastic:master Mar 16, 2021
@tsullivan tsullivan deleted the apparch/enable-csv-searchsource branch March 16, 2021 16:34
@tsullivan tsullivan mentioned this pull request Mar 16, 2021
Merged
tsullivan added a commit to tsullivan/kibana that referenced this pull request Mar 16, 2021
@tsullivan
App Services API updates for CSV Export (elastic#94537)
e801d71 
* App Arch API updates for CSV Export

* add logging to show error cause from es

* revert logging the error in an inconsistent way
tsullivan added a commit that referenced this pull request Mar 16, 2021
@tsullivan
App Services API updates for CSV Export (#94537) (#94727)
3fb9a4f 
* App Arch API updates for CSV Export

* add logging to show error cause from es

* revert logging the error in an inconsistent way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kertal kertal kertal left review comments

@ppisljar ppisljar ppisljar approved these changes

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tsullivan @elasticmachine @kibanamachine @kertal @ppisljar