Conversation
Backports PR #9044 **Commit 1:** renaming x-axis to axis moving y-axis methods inside axis class updating handler to use Axis for yAxis as well introducting 'type' property to differ between X and Y axis joining x_axis and y_axis into a single class axis - splitting it into 3 subclasses (Axis, AxisLabels, AxisScale) - converting to ES6 classes + style fixes - adding more customization options updating handler to work with new Axis class - allowing handler to have multiple category/value axes (array) converting axis_title to ES6 classes and making it work with new axis updating column layout to support left/right top/bottom positioning of axis - updating css min-widths to 1px (removing them breaks the code) as we dont want to reserve the space for axes that dont exist. introducing AxisConfig class adding ordered and values back to axis to make other parts of vislib working renaming axis.scale to axis.axisScale removing comments adding scale type config removing unnecesarry configs (never used) adding point series chart type updating all charts introducing VisConfig class moving wiggle, silluete and stacking to axis fixing based on last spencers review add label to zero filled values allow custom values on catwegory axis adding clip path updating defaults to match current vislib implementation seri.show parameter vertical category axis positioning fixing more issues fixing broken pie charts increasing default truncate length fixing expandLastBucket option * Original sha: ba74498 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-13T10:59:17Z **Commit 2:** fixing selenium tests by increasing barHeightTolerance * Original sha: f27f8a1 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-22T09:40:25Z **Commit 3:** fixing axis alignment (1px off) * Original sha: 3d6267e * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-22T12:19:37Z **Commit 4:** fixing layout elements min-height to 0 * Original sha: 619a495 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-22T12:20:20Z **Commit 5:** point radius should be calculated per chart * Original sha: be16b14 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-22T13:35:27Z **Commit 6:** adding clip path to circles * Original sha: 188131b * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-22T13:43:55Z **Commit 7:** seting min height 0 on axis * Original sha: 231a58a * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-22T14:45:12Z **Commit 8:** adding background class * Original sha: c41e672 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-22T15:27:02Z **Commit 9:** fixing selenium tests * Original sha: ed1b330 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-22T15:27:40Z **Commit 10:** update visualize legend to correctly check if it should show * Original sha: 9bd80be * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-23T10:33:06Z **Commit 11:** fixing based on CJs comments * Original sha: 02a22d0 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-12-01T06:44:37Z **Commit 12:** improving stacking of negative values * Original sha: 9d79d79 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-12-01T06:55:33Z **Commit 13:** updating class name to better match element * Original sha: 628408d * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-12-01T06:56:11Z **Commit 14:** fixing charts with mixed (negative/positive) values * Original sha: 682ab0b * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-12-01T09:44:49Z **Commit 15:** fixing test (stacking happens for grouped charts as well to handle negative values correctly) * Original sha: 69a53ea * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-12-01T09:52:29Z **Commit 16:** fixing based on CJs last comments * Original sha: 9e8d71f * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-12-01T16:05:31Z **Commit 17:** fixing unstable selenium test * Original sha: f36b6fc * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-12-06T11:20:30Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vislib Point Series updates
Backports PR #9044
Commit 1:
renaming x-axis to axis
moving y-axis methods inside axis class
updating handler to use Axis for yAxis as well
introducting 'type' property to differ between X and Y axis
joining x_axis and y_axis into a single class axis
updating handler to work with new Axis class
converting axis_title to ES6 classes and making it work with new axis
updating column layout to support left/right top/bottom positioning of axis
introducing AxisConfig class
adding ordered and values back to axis to make other parts of vislib working
renaming axis.scale to axis.axisScale
removing comments
adding scale type config
removing unnecesarry configs (never used)
adding point series chart type
updating all charts
introducing VisConfig class
moving wiggle, silluete and stacking to axis
fixing based on last spencers review
add label to zero filled values
allow custom values on catwegory axis
adding clip path
updating defaults to match current vislib implementation
seri.show parameter
vertical category axis positioning
fixing more issues
fixing broken pie charts
increasing default truncate length
fixing expandLastBucket option
Commit 2:
fixing selenium tests by increasing barHeightTolerance
Commit 3:
fixing axis alignment (1px off)
Commit 4:
fixing layout elements min-height to 0
Commit 5:
point radius should be calculated per chart
Commit 6:
adding clip path to circles
Commit 7:
seting min height 0 on axis
Commit 8:
adding background class
Commit 9:
fixing selenium tests
Commit 10:
update visualize legend to correctly check if it should show
Commit 11:
fixing based on CJs comments
Commit 12:
improving stacking of negative values
Commit 13:
updating class name to better match element
Commit 14:
fixing charts with mixed (negative/positive) values
Commit 15:
fixing test (stacking happens for grouped charts as well to handle negative values correctly)
Commit 16:
fixing based on CJs last comments
Commit 17:
fixing unstable selenium test