Skip to content

[7.x] rename advanced setting ml:fileDataVisualizerMaxFileSize to fileUpload:maxFileSize and increase max geojson upload size to 1GB (#92620)#93358

Merged
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-92620
Mar 3, 2021
Merged

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Mar 3, 2021

Backports the following commits to 7.x:

…d:maxFileSize and increase max geojson upload size to 1GB (elastic#92620)

* rename ml:fileDataVisualizerMaxFileSize to fileUppload:maxFileSize

* add saved object migration

* file preview

* importing status

* remove console statement

* import complete view

* fix geojson_importer test

* tslint

* i18n fixes

* cleanup

* update documenation for advanced setting rename

* advanced settings usage_collection

* remove ml:fileDataVisualizerMaxFileSize from schemas and types

* add copy buttons for import response and fix geojson upload functional tests

* tslint

* remove clipboard-read check

* return early if env does not support reading from clipboard

* fix reporting tests

* review feedback

* update GeoJsonFileSource to support showing results trimmed icon and tooltip

* add fileUpload to useMlKibana context and replace dependencyCache with useMlKibana

* tslint

* review feedback

* lower case file name

* default to selecting geo_shape when file contains both points and shapes

* fix wizard onError callback to not advance to next step

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@nreese nreese added the backport This PR is a backport of another PR label Mar 3, 2021
@nreese nreese enabled auto-merge (squash) March 3, 2021 02:08
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fileUpload 197 199 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fileUpload 826.0KB 825.0KB -1.0KB
maps 2.7MB 2.7MB +724.0B
ml 6.4MB 6.4MB -452.0B
total -759.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fileUpload 11.5KB 13.7KB +2.2KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit b7bfbef into elastic:7.x Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants