Skip to content

Enable APM storybook publishing#93353

Merged
smith merged 4 commits intoelastic:masterfrom
smith:nls/apm-sb
Mar 8, 2021
Merged

Enable APM storybook publishing#93353
smith merged 4 commits intoelastic:masterfrom
smith:nls/apm-sb

Conversation

@smith
Copy link
Contributor

@smith smith commented Mar 3, 2021

Changes to fix APM's Storybook setup were made in #93087 and #93294. This re-enables it and fixes a couple places where we weren't using a theme provider.

Changes to fix APM's Storybook setup were made in elastic#93087 and elastic#93294. This re-enables it and fixes a couple places where we weren't using a theme provider.
@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 3, 2021
@smith smith requested a review from a team March 3, 2021 00:14
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Mar 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith
Copy link
Contributor Author

smith commented Mar 5, 2021

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Mar 8, 2021

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Mar 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 749a229 into elastic:master Mar 8, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 8, 2021
Changes to fix APM's Storybook setup were made in elastic#93087 and elastic#93294. This re-enables it and fixes a couple places where we weren't using a theme provider.
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #93964

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 8, 2021
Changes to fix APM's Storybook setup were made in #93087 and #93294. This re-enables it and fixes a couple places where we weren't using a theme provider.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants