[Security Solution][Case][Bug] Only add rule object for alert comments#92977
Merged
jonathan-buttner merged 4 commits intoelastic:masterfrom Mar 1, 2021
Merged
Conversation
jonathan-buttner
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
30 tasks
cnasikas
reviewed
Mar 1, 2021
| .set('kbn-xsrf', 'true') | ||
| .send() | ||
| .expect(200); | ||
| describe('7.11.1', () => { |
Member
There was a problem hiding this comment.
nit: I think 7.11 is better as label as it targets the whole transition from 7.11 to 7.12. 7.11.1 is a bit confusing as it seems that this test in only for 7.11.1 and not 7.11. The same for folder structure: cases/migrations/7.11.1
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! Yeah I'll add more of a description. I chose 7.11.1 because that's the stack version I used to generate the data so I think I'll leave that as the directory name.
cnasikas
approved these changes
Mar 1, 2021
Member
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jonathan-buttner
added a commit
to jonathan-buttner/kibana
that referenced
this pull request
Mar 1, 2021
elastic#92977) * Adding test for alert rule fields migration * Fixing directory issue * Add more descriptive message Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jonathan-buttner
added a commit
to jonathan-buttner/kibana
that referenced
this pull request
Mar 1, 2021
elastic#92977) * Adding test for alert rule fields migration * Fixing directory issue * Add more descriptive message Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jonathan-buttner
added a commit
that referenced
this pull request
Mar 1, 2021
#92977) (#93061) * Adding test for alert rule fields migration * Fixing directory issue * Add more descriptive message Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jonathan-buttner
added a commit
that referenced
this pull request
Mar 1, 2021
#92977) (#93060) * Adding test for alert rule fields migration * Fixing directory issue * Add more descriptive message Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
that referenced
this pull request
Mar 3, 2021
… ilm/rollup-v2-action * 'ilm/rollup-v2-action' of github.com:elastic/kibana: [Security Solution][Case][Bug] Only add rule object for alert comments (#92977) [Security Solution][Case] Show the current connector name in case view (#93018) [Security Solution] Remove unused mock data (#92357) Adds mapping to the signals for the indicator rules that were missing (#92928) skip flaky suite (#85208) Cleanup spaces plugin (#91976) Control round and decimal places in Gauge Visualization when using aggregate functions like average (#91293) Added alerting ui mock for jest test (#92604) Remove "beta" label from URL Drilldown as it is now GA (#92859)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the migration for 7.12 to only add the
ruleobject for alert comments instead of all comments.Issue: #91843