[plugin cli] Retry folder rename on windows eperm #9260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - I tested installing x-pack with these changes on Windows, and it worked. |
Contributor
|
LGTM |
This was referenced Nov 30, 2016
elastic-jasper
added a commit
that referenced
this pull request
Nov 30, 2016
Backports PR #9260 **Commit 1:** [plugin cli] Retry folder rename on windows eperm * Original sha: 398662f * Authored by Jonathan Budzenski <[email protected]> on 2016-11-29T20:05:19Z
elastic-jasper
added a commit
that referenced
this pull request
Nov 30, 2016
Backports PR #9260 **Commit 1:** [plugin cli] Retry folder rename on windows eperm * Original sha: 398662f * Authored by Jonathan Budzenski <[email protected]> on 2016-11-29T20:05:19Z
epixa
pushed a commit
that referenced
this pull request
Nov 30, 2016
Backports PR #9260 **Commit 1:** [plugin cli] Retry folder rename on windows eperm * Original sha: 398662f * Authored by Jonathan Budzenski <[email protected]> on 2016-11-29T20:05:19Z
epixa
pushed a commit
that referenced
this pull request
Nov 30, 2016
Backports PR #9260 **Commit 1:** [plugin cli] Retry folder rename on windows eperm * Original sha: 398662f * Authored by Jonathan Budzenski <[email protected]> on 2016-11-29T20:05:19Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#9260 **Commit 1:** [plugin cli] Retry folder rename on windows eperm * Original sha: 398662f * Authored by Jonathan Budzenski <[email protected]> on 2016-11-29T20:05:19Z Former-commit-id: 0fd25ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows machines, there can be EPERM failures during plugin installation when trying to rename extracted plugin files. This usually seems to be a result of AV software temporarily locking new files. Instead of failing immediately, this retries renaming for up to 3 seconds, before giving up and throwing the original error.
Closes #9046